From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Jean Delvare" <khali@linux-fr.org>
Cc: "Greg KH" <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>,
"David Brownell" <david-b@pacbell.net>
Subject: Re: Platform device id
Date: Fri, 7 Sep 2007 10:58:31 -0400 [thread overview]
Message-ID: <d120d5000709070758i1b54a37o3d3977304a84b2c1@mail.gmail.com> (raw)
In-Reply-To: <20070907153559.17faf9d1@hyperion.delvare>
Hi Jean,
On 9/7/07, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Greg, all,
>
> While platform_device.id is a u32, platform_device_add() handles "-1" as
> a special id value. This has potential for confusion and bugs. One such
> bug was reported to me by David Brownell:
>
> http://lists.lm-sensors.org/pipermail/i2c/2007-September/001787.html
>
> And since then I've found two other drivers affected (uartlite and
> i2c-pxa).
>
> Could we at least make platform_device.id an int so as to clear up the
> confusion? I doubt that the id will ever be a large number anyway.
>
> To go one step further, I am questioning the real value of this naming
> exception for these "unique" platform devices. On top of the bugs I
> mentioned above, it has potential for compatibility breakage: adding a
> second device of the same type will rename the first one from "foo" to
> "foo.0". It also requires specific checks in many individual platform
> drivers. All this, as I understand it, for a purely aesthetic reason. I
> don't think this is worth it. Would there be any objection to simply
> getting rid of this exception and having all platform devices named
> "foo.%d"?
>
If a device has a <name>.<instance> scheme this implies possibility of
having several instances of said device in a box. There are a few of
platform devices that can only have one instance - for example i8042
keyboard controller (the -1 special handling came from me because
i80420 name was very confusing - there wasn't a dot separator in the
name back then). Drivers that allow multiple devices should not
attempt to use -1 for the very first instance - this should eliminate
potential for error and special handling that you are talking about.
--
Dmitry
next prev parent reply other threads:[~2007-09-07 14:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 13:35 Jean Delvare
2007-09-07 14:58 ` Dmitry Torokhov [this message]
2007-09-07 16:36 ` Jean Delvare
2007-09-07 16:41 ` David Brownell
2007-09-07 21:00 ` Henrique de Moraes Holschuh
2007-09-07 21:41 ` David Brownell
2007-09-07 22:04 ` Henrique de Moraes Holschuh
2007-09-08 0:18 ` David Brownell
2007-09-08 3:50 ` Henrique de Moraes Holschuh
2007-09-08 8:55 ` Jean Delvare
2007-09-10 22:52 ` Henrique de Moraes Holschuh
2007-09-11 7:43 ` Jean Delvare
2007-09-11 13:44 ` Henrique de Moraes Holschuh
2007-09-11 14:05 ` Jean Delvare
2007-09-07 20:56 ` Henrique de Moraes Holschuh
2007-09-08 8:40 ` Jean Delvare
2007-09-10 22:45 ` Henrique de Moraes Holschuh
2007-09-08 13:30 ` Greg KH
2007-09-09 10:54 ` [PATCH] Make platform_device.id an int Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000709070758i1b54a37o3d3977304a84b2c1@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®