mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Adrian McMenamin" <lkmladrian@gmail.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
	linux-kernel@vger.kernel.org, linuxsh-dev@lists.sourceforge.net
Subject: Re: [PATCH 2/2] Maple bus support for the SEGA Dreamcast - Dreamcast keyboard support
Date: Tue, 11 Sep 2007 01:25:58 -0400	[thread overview]
Message-ID: <d120d5000709102225n516d9c17m2120b64cef801625@mail.gmail.com> (raw)
In-Reply-To: <8b67d60709101617n564daf28s83212469d879d00d@mail.gmail.com>

On 9/10/07, Adrian McMenamin <lkmladrian@gmail.com> wrote:
> +
> +	for (i = 0; i < NR_SCANCODES; i++)
> +		memcpy(kbd->keycode + i * sizeof(unsigned char), dc_kbd_keycode + i
> * sizeof(unsigned char),
> +				 sizeof(unsigned char));

Ahem... That's not what I had in mind when I asked for memcpy. How about:

        memcpy(kbd->keycode, dc_kbd_keycode, sizeof(kbd->keycode);

?

Thanks.

-- 
Dmitry

      reply	other threads:[~2007-09-11  5:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 23:17 Adrian McMenamin
2007-09-11  5:25 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000709102225n516d9c17m2120b64cef801625@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxsh-dev@lists.sourceforge.net \
    --cc=lkmladrian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®