mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Anti Sullin" <anti.sullin@artecdesign.ee>
Cc: LKML <linux-kernel@vger.kernel.org>,
	akpm@linux-foundation.org, david-b@pacbell.net
Subject: Re: [PATCH 1/2] gpio_keys: add gpio_to_irq return code check
Date: Tue, 18 Sep 2007 11:59:28 -0400	[thread overview]
Message-ID: <d120d5000709180859r48f0d123h339884dcf481f001@mail.gmail.com> (raw)
In-Reply-To: <46EFF22A.9010509@artecdesign.ee>

Hi Anti,

On 9/18/07, Anti Sullin <anti.sullin@artecdesign.ee> wrote:
> As David Brownell pointed out when reviewing my suspend patch to
> gpio_keys, the original gpio_keys driver does not check gpio_to_irq
> return code.
>
...
> -               set_irq_type(irq, IRQ_TYPE_EDGE_BOTH);
> -               error = request_irq(irq, gpio_keys_isr, IRQF_SAMPLE_RANDOM,
> -                                    button->desc ? button->desc : "gpio_keys",
> -                                    pdev);
> +               if (irq < 0)

What would be the value of error variable (that we use as a return value) here?

> +                       goto fail;
> +

-- 
Dmitry

      reply	other threads:[~2007-09-18 15:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 15:43 Anti Sullin
2007-09-18 15:59 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000709180859r48f0d123h339884dcf481f001@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anti.sullin@artecdesign.ee \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®