mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Kristoffer Ericson" <kristoffer.ericson@gmail.com>
Cc: linux-input <linux-input@atrey.karlin.mff.cuni.cz>,
	linux-main <linux-kernel@vger.kernel.org>,
	"Richard Purdie" <rpurdie@rpsys.net>
Subject: Re: Power button policy and mechanism
Date: Tue, 16 Oct 2007 10:34:26 -0400	[thread overview]
Message-ID: <d120d5000710160734occe82cke989baf3d1f97130@mail.gmail.com> (raw)
In-Reply-To: <20071016134050.f7106efe.Kristoffer.Ericson@Gmail.com>

Hi Kristoffer,

On 10/16/07, Kristoffer Ericson <kristoffer.ericson@gmail.com> wrote:
> Greetings Dmitry,
>
> Is the suggested approach on handling powerbutton (in keyboard driver) to simply push out the event and let userland handle it?

Yes.

> The reason Im asking this is because as you might know Im maintainer for two mini-laptop style pda's (HP7xx & HP6xx)
> and it would simplify my life alot if I didn't need to depend on userland applications to be able to suspend/resume.
>
> For instance HP6XX receives an interrupt call whenever the powerbutton is pressed. Now I could just push out the event and let another program handle it but considering it would take a minimum amount of lines to let it simply suspend/resume I feel its a waste.
>
> Previously the hp6xx has been allowed to do this "policy" way but that was when LinuxSH stod as a side branch to main tree. Now
> when everything gets merged into mainline I need to decide how to do this.
>
> This is mainly an embedded issue, but I feel it's quite important. It should apply to other devices also like for example Zaurus branches (those with keyboard and designated power button).
>
> So in short:
> 1. Does mainline policy allow static power button events inside kernel (power button == suspend/resume)?
>        Why/Why Not?

Could it be that you may want to prevent suspend from happening? Or
delay it until system completes some important operation? Do something
else, like cleanly disconnect your network connections? With actual
handling done in userspace it's all possible. With suspend done
directly in kernel it is much harder and couples input subsystem with
power management too tightly.

However if you are dead-set on doin it in kernel you coudl register an
input_handler in your platform PM code and it will attach to your
keyboard. Look for power.c module in older kernels for example.

> 2. Seeing as my knowledge about this area isn't the best I would appreciate all opinions on the subject from the gurus.
>

Richard Purdie I think might have some pointers.

-- 
Dmitry

  reply	other threads:[~2007-10-16 14:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 20:40 Kristoffer Ericson
2007-10-16 14:34 ` Dmitry Torokhov [this message]
2007-10-19  9:54   ` Richard Purdie
2007-10-19 15:04     ` Dmitry Torokhov
2007-10-20 21:42     ` Kristoffer Ericson
     [not found] <9eSWm-5sS-7@gated-at.bofh.it>
     [not found] ` <9eVKz-1xq-17@gated-at.bofh.it>
2007-10-16 20:29   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000710160734occe82cke989baf3d1f97130@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=kristoffer.ericson@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome