From: Waiman Long <longman@redhat.com>
To: "Zhang, Qiang" <Qiang.Zhang@windriver.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"elver@google.com" <elver@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: 回复: [PATCH] debugobjects: install cpu hotplug callback
Date: Tue, 25 Aug 2020 19:32:40 -0400 [thread overview]
Message-ID: <d1255075-e273-a74d-3bc7-d97b320470db@redhat.com> (raw)
In-Reply-To: <e75c1601-b466-8476-f75b-514b1c21646e@redhat.com>
On 8/25/20 6:26 PM, Waiman Long wrote:
> On 8/25/20 12:53 AM, Zhang, Qiang wrote:
>> ________________________________________
>> 发件人: linux-kernel-owner@vger.kernel.org
>> <linux-kernel-owner@vger.kernel.org> 代表 qiang.zhang@windriver.com
>> <qiang.zhang@windriver.com>
>> 发送时间: 2020年8月20日 11:24
>> 收件人: tglx@linutronix.de; elver@google.com; longman@redhat.com
>> 抄送: linux-kernel@vger.kernel.org
>> 主题: [PATCH] debugobjects: install cpu hotplug callback
>>
>> From: Zqiang <qiang.zhang@windriver.com>
>>
>> When a cpu going offline, we should free objects in "percpu_obj_pool"
>> free_objs list which corresponding to this cpu.
>
> The percpu free object pool is supposed to be accessed only by that
> particular cpu without any lock. Trying to access it from another cpu
> can cause a race condition unless one can make sure that the offline
> cpu won't become online in the mean time. There shouldn't be too many
> free objects in the percpu pool. Is it worth the effort to free them?
Or if you can make the to-be-offlined cpu free the debugobjs before it
is offlined. That will work too.
Cheers,
Longman
next prev parent reply other threads:[~2020-08-25 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 3:24 qiang.zhang
2020-08-25 4:53 ` 回复: " Zhang, Qiang
2020-08-25 22:26 ` Waiman Long
2020-08-25 23:32 ` Waiman Long [this message]
2020-08-25 23:53 ` Thomas Gleixner
2020-08-26 0:48 ` Waiman Long
2020-08-26 8:34 ` 回复: " Zhang, Qiang
2020-08-26 9:41 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1255075-e273-a74d-3bc7-d97b320470db@redhat.com \
--to=longman@redhat.com \
--cc=Qiang.Zhang@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®