From: "Budai, Robert" <Robert.Budai@analog.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
Andy Shevchenko <andy@kernel.org>,
"Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
"Gradinariu, Ramona" <Ramona.Gradinariu@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: imu: adis16550: fix swapped gyro/accel filter functions
Date: Tue, 3 Mar 2026 12:40:35 +0000 [thread overview]
Message-ID: <d1274cf4b7824cdea509d6ad5a48c291@analog.com> (raw)
In-Reply-To: <20260227122046.46710-1-antoniu.miclaus@analog.com>
> -----Original Message-----
> From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Sent: Friday, February 27, 2026 2:21 PM
> To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> Andy Shevchenko <andy@kernel.org>; Budai, Robert
> <Robert.Budai@analog.com>; Miclaus, Antoniu
> <Antoniu.Miclaus@analog.com>; Gradinariu, Ramona
> <Ramona.Gradinariu@analog.com>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] iio: imu: adis16550: fix swapped gyro/accel filter functions
>
> The low-pass filter handlers for IIO_ANGL_VEL and IIO_ACCEL call each
> other's filter functions in both read_raw and write_raw. Swap them so
> each channel type uses its correct filter accessor.
>
> Fixes: bac4368fab62 ("iio: imu: adis16550: add adis16550 support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
Acked-by: Robert Budai <robert.budai@analog.com>
> drivers/iio/imu/adis16550.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/adis16550.c b/drivers/iio/imu/adis16550.c
> index 28f0dbd0226c..1f2af506f4bd 100644
> --- a/drivers/iio/imu/adis16550.c
> +++ b/drivers/iio/imu/adis16550.c
> @@ -643,12 +643,12 @@ static int adis16550_read_raw(struct iio_dev
> *indio_dev,
> case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
> switch (chan->type) {
> case IIO_ANGL_VEL:
> - ret = adis16550_get_accl_filter_freq(st, val);
> + ret = adis16550_get_gyro_filter_freq(st, val);
> if (ret)
> return ret;
> return IIO_VAL_INT;
> case IIO_ACCEL:
> - ret = adis16550_get_gyro_filter_freq(st, val);
> + ret = adis16550_get_accl_filter_freq(st, val);
> if (ret)
> return ret;
> return IIO_VAL_INT;
> @@ -681,9 +681,9 @@ static int adis16550_write_raw(struct iio_dev
> *indio_dev,
> case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
> switch (chan->type) {
> case IIO_ANGL_VEL:
> - return adis16550_set_accl_filter_freq(st, val);
> - case IIO_ACCEL:
> return adis16550_set_gyro_filter_freq(st, val);
> + case IIO_ACCEL:
> + return adis16550_set_accl_filter_freq(st, val);
> default:
> return -EINVAL;
> }
> --
> 2.43.0
prev parent reply other threads:[~2026-03-03 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 12:20 Antoniu Miclaus
2026-02-27 16:33 ` Andy Shevchenko
2026-03-07 14:12 ` Jonathan Cameron
2026-03-03 12:40 ` Budai, Robert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1274cf4b7824cdea509d6ad5a48c291@analog.com \
--to=robert.budai@analog.com \
--cc=Antoniu.Miclaus@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Ramona.Gradinariu@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®