From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D4A722B5B1 for ; Thu, 27 Feb 2025 11:12:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740654758; cv=none; b=ZifCkIFJx31GxnlFUvJlVaikMsTr2SRnuQ3fk4aeaAI01Mn1eLZERQuEa09F9Gl8RgNqjMKTihosM9vinLFjD/GwJqj1v3Mpkymrgpmn+S1ToEYSfltu56+Yln7KrNTmZUhkLU0xFzrj7fajJxVHg8N1ZKq/lyOsWdkB18g9cPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740654758; c=relaxed/simple; bh=cWvQd45e0S+D3yV/mKOMz2NTuAJ8xsra4qpJ1phNXVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L80D7WkcasX8Kg0muyFGJa6R1RGmCb6rkITAMkXmGT1zOj9mv20FeKQv9bZ3RYVI1/K/RWp0Sv+2FZ+wKIwJrAhqkQFC5TsZ07BMG2x8lXiXxfZiPpPklDNrA2+LhBWfEnYQP2Xyyocn9Z8MZxFSk+krmPR90h0CzGFALlIwBaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IzR+uqXk; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IzR+uqXk" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-390df0138beso424496f8f.0 for ; Thu, 27 Feb 2025 03:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740654755; x=1741259555; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G+ydNLQoguFN2ZMM4/Ua1quaGwPmvX9Lj6xdcBbBMyE=; b=IzR+uqXkXPG/4Ax+x2zyfJvyw05xHbgmM8KbD3WZ6/UG81omfIo6ujjcA9YBO/aFo7 clk24RC5Dbfr4+GPnR7mxe1tB3C4gSc2cW6mb4Z2EYPto8zAiCtXFPTYRwXknd9LVDEk jcVCZR54S7BTO/o93/vG7Xt/dWt8Tchrff9XZ3P9Not3hyBo0Pg333Ahf+XFxCbMQ00S wG5NgS06xOLPXN5E+4vf86xqRnKc159fjmxNsfgnLgqSAGrH3MF4i1AlIWBmGpmYI9E3 LE3ttoJX11xM6d2ZOKOv4e9Qx0OKDKjfnfg1QwhmCwY+C0bWDzjBSBw0tAp2vi98yi5+ pW5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740654755; x=1741259555; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G+ydNLQoguFN2ZMM4/Ua1quaGwPmvX9Lj6xdcBbBMyE=; b=Ss7MP5tVC06orzbCfhQkEbAv5NSZrwRx5hgfdGSnfwooa0c4sfnHzElxQ3dyiwV6Bq fxEx/ekzYtA+D4AP8LGveYlh5IGIqjhhVu1UuhIRv1z8rfBjzZTD6EPItrnDTCJyoPXM lQgJAjCpSLj+ImFKQjSzk/db5xYDwnBh2678a9j14Z2KAimfPxx8eK2gOv7TNSZPHa5X e6184pS7Kn1YE/Wi0pwVA9Q9gi2ZVG/KAfQtpk971wgkMr2Yo3CY9AAr9fFTRS1ktuTb eAm4g+s1U5Pr/dJHi5cAp27NEmtJmJIq4jPM6pohgzMrzOAZuY2QooD8EnYktyJdmMQu suiQ== X-Forwarded-Encrypted: i=1; AJvYcCX6nP4uavlpfKFe+Q/oramL7v3B0KUgf/nuphKZeJf9bfFrhTzA2Q9Pg+U0IC//Bx8P47TeOwDD49SscTc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9pDyLfdWED98O7p1ZUcSwspv3m0QEdG8HtZzN6dbdhJVgO9Td v0fPazFQ/kUiImgGw7mkHOOuZoWCXuPiWlH/+jLuppIrKAp8yUfg062zMtvbXMY= X-Gm-Gg: ASbGncuIY1LI+dRUcVGIzMtjzhonR5nCOwPKl8axVjd6IQfion9bSvEHjBFIuLmDTmQ VjnH+IDvNw7sJtXpRgwUKHJNgkCPV6pAoGRvXBDfmIcM7kIPxuqHQhl72wQe7FCiTrmC5LpwV6H Qi5hzQamkiMoNM6VN/AxmVp5g1C85EE4vzAzR52Nyc6mUiTC4IV0cMm4W0bIh7AoVXq2fDMxmH4 nrzk96bLq9X1atrgnWVBv/UgfKhx9kUuqxOoU4y1y8/KlPXIgcfnFw3k9qe5rOovf884trLBMFl oFhKwngveLL8NHLb1jkyDHJ6+I5kFxbdK6eQ1db21O16wiOhz5SsfdxS2Yz4AGp1+6E= X-Google-Smtp-Source: AGHT+IGsu0/E8jwYIek/GteGM+K/6JJMnT+CYFPA/DJ68QSbr9KadQE92Npw2peeqfSDb/VDW47cJg== X-Received: by 2002:a5d:6da5:0:b0:38d:df70:23cf with SMTP id ffacd0b85a97d-38f6e9470ebmr20449134f8f.16.1740654754906; Thu, 27 Feb 2025 03:12:34 -0800 (PST) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b7a27aa69sm18821095e9.29.2025.02.27.03.12.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2025 03:12:34 -0800 (PST) Message-ID: Date: Thu, 27 Feb 2025 11:12:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] {vision/navigation}-mezzanine: Fix overlay root node To: Nikita Travkin , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250226-qcom-nonroot-overlays-v1-0-26c6e7605833@trvn.ru> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250226-qcom-nonroot-overlays-v1-0-26c6e7605833@trvn.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/02/2025 14:29, Nikita Travkin wrote: > While considering to propose WoA EL2 dt overlays upstream I was looking > at existing overlays and noticed that some of them are broken: they put > seemingly meaningful fixups into the overlay's "/" node, which places > them into the overlay "metadata" itself, not into a fixup fragment to be > applied to the actual dtb. This series fixes those two by changing to > full path "&{/}" which should work as it was initially intended. > > See demonstration of the problem below: > > $ cat base.dts > /dts-v1/; > / { > compatible = "fake,board"; > fake,value = <42>; > }; > > $ cat extra.dtso > /dts-v1/; > /plugin/; > > / { > foo; > bar { baz; }; > }; > &{/} { whatever-comes-next-after-baz; }; > > $ dtc base.dts -o base.dtb > $ dtc extra.dtso -o extra.dtbo > $ fdtoverlay -i base.dtb -o combine.dtb extra.dtbo > $ dtc base.dtb > /dts-v1/; > > / { > compatible = "fake,board"; > fake,value = <0x2a>; > }; > > $ dtc extra.dtbo > /dts-v1/; > > / { > foo; > > bar { > baz; > }; > > fragment@0 { > target-path = "/"; > > __overlay__ { > whatever-comes-next-after-baz; > }; > }; > }; > > $ dtc combine.dtb > /dts-v1/; > > / { > whatever-comes-next-after-baz; > compatible = "fake,board"; > fake,value = <0x2a>; > }; > > In the resulting dtb foo bar and baz are missing. > > Signed-off-by: Nikita Travkin > --- > Nikita Travkin (2): > arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Fix broken overlay root > arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Fix the overlay root > > arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dtso | 2 +- > arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > --- > base-commit: 8433c776e1eb1371f5cd40b5fd3a61f9c7b7f3ad > change-id: 20250226-qcom-nonroot-overlays-bfe21d33be8c > > Best regards, This is a good find however, we should just drop these additional CMA heap nodes as the reason for their original addition has been superseded. libcamera can now use UDMA buf for the same purpose as the CMA heap, without the security concerns of CMA to distros. You only need the CMA heap when you require uncached physically contiguous buffers - for example Hantro on iMX but, this is not the case on qcom hardware. We can safely drop these CMA nodes for CAMSS. --- bod