From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbeATJd2 (ORCPT ); Sat, 20 Jan 2018 04:33:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:50984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbeATJdT (ORCPT ); Sat, 20 Jan 2018 04:33:19 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AE88214E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: recover some i_inline flags To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20180120042643.20717-1-jaegeuk@kernel.org> <20180120042643.20717-2-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Sat, 20 Jan 2018 17:33:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180120042643.20717-2-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/1/20 12:26, Jaegeuk Kim wrote: > This fixes lost i_inline flags during roll-forward. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/recovery.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index cbeef73bc4dd..2354f1e05e19 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -211,6 +211,15 @@ static void recover_inode(struct inode *inode, struct page *page) > > F2FS_I(inode)->i_advise = raw->i_advise; How about adding recover_inline_flags() including below changes? > > + if (raw->i_inline & F2FS_PIN_FILE) > + set_inode_flag(inode, FI_PIN_FILE); else clear_inode_flag(inode, FI_PIN_FILE); ? Thanks, > + if (raw->i_inline & F2FS_DATA_EXIST) > + set_inode_flag(inode, FI_DATA_EXIST); > + else > + clear_inode_flag(inode, FI_DATA_EXIST); > + if (!(raw->i_inline & F2FS_INLINE_DOTS)) > + clear_inode_flag(inode, FI_INLINE_DOTS); > + > if (file_enc_name(inode)) > name = ""; > else >