Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588 boards

[Christopher Obbard <chris.obbard@collabora.com>]

On Wed, 2022-12-14 at 19:22 +0100, Sebastian Reichel wrote:
> Add DT binding documentation for the Rockchip RK3588 EVB1,
> Radxa Rock 5 Model A and B.
> 
> Co-Developed-by: Christopher Obbard <chris.obbard@collabora.com>
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  .../devicetree/bindings/arm/rockchip.yaml         | 15
> +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index c6c69a4e3777..49d442afe67f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -620,6 +620,16 @@ properties:
>            - const: radxa,rock3a
>            - const: rockchip,rk3568
>  
> +      - description: Radxa Rock 5 Model A
> +        items:
> +          - const: radxa,rock-5a
> +          - const: rockchip,rk3588s
> +
> +      - description: Radxa Rock 5 Model B

Hi Sebastian,

To better match other boards from this vendor (e.g. RADXA ROCK 4)

would it be best to capitalise this (and obviously the model field in
the respective DTS patches) the same?

So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".

It's also capitalised this way on the documentation website [1].

(I think the vendor has specifically dropped the Pi reference from
these boards, but I don't know why)

Thanks!
Chris

[1]: https://wiki.radxa.com/Rock5/5B



> +        items:
> +          - const: radxa,rock-5b
> +          - const: rockchip,rk3588
> +
>        - description: Rikomagic MK808 v1
>          items:
>            - const: rikomagic,mk808
> @@ -704,6 +714,11 @@ properties:
>            - const: rockchip,rk3399-sapphire-excavator
>            - const: rockchip,rk3399
>  
> +      - description: Rockchip RK3588 Evaluation board
> +        items:
> +          - const: rockchip,rk3588-evb1-v10
> +          - const: rockchip,rk3588
> +
>        - description: Rockchip RV1108 Evaluation board
>          items:
>            - const: rockchip,rv1108-evb
> -- 
> 2.39.0
> 
>