From: Kexy Biscuit <kexybiscuit@aosc.io>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org,
linux_oss@crudebyte.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
m.grzeschik@pengutronix.de, gregkh@linuxfoundation.org,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] net/9p/usbg: Fix build error
Date: Fri, 4 Oct 2024 01:37:56 +0800 [thread overview]
Message-ID: <d1383f52-b1b3-4967-8bd1-abb42fedba4f@aosc.io> (raw)
In-Reply-To: <20240930081520.2371424-1-ruanjinjie@huawei.com>
On 9/30/2024 4:15 PM, Jinjie Ruan wrote:
> When CONFIG_NET_9P_USBG=y but CONFIG_USB_LIBCOMPOSITE=m and
> CONFIG_CONFIGFS_FS=m, the following build error occurs:
>
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_free_func':
> trans_usbg.c:(.text+0x124): undefined reference to `usb_free_all_descriptors'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_rx_complete':
> trans_usbg.c:(.text+0x2d8): undefined reference to `usb_interface_id'
> riscv64-unknown-linux-gnu-ld: trans_usbg.c:(.text+0x2f6): undefined reference to `usb_string_id'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_func_bind':
> trans_usbg.c:(.text+0x31c): undefined reference to `usb_ep_autoconfig'
> riscv64-unknown-linux-gnu-ld: trans_usbg.c:(.text+0x336): undefined reference to `usb_ep_autoconfig'
> riscv64-unknown-linux-gnu-ld: trans_usbg.c:(.text+0x378): undefined reference to `usb_assign_descriptors'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `f_usb9pfs_opts_buflen_store':
> trans_usbg.c:(.text+0x49e): undefined reference to `usb_put_function_instance'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_alloc_instance':
> trans_usbg.c:(.text+0x5fe): undefined reference to `config_group_init_type_name'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_alloc':
> trans_usbg.c:(.text+0x7aa): undefined reference to `config_ep_by_speed'
> riscv64-unknown-linux-gnu-ld: trans_usbg.c:(.text+0x7ea): undefined reference to `config_ep_by_speed'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_set_alt':
> trans_usbg.c:(.text+0x828): undefined reference to `alloc_ep_req'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_modexit':
> trans_usbg.c:(.exit.text+0x10): undefined reference to `usb_function_unregister'
> riscv64-unknown-linux-gnu-ld: net/9p/trans_usbg.o: in function `usb9pfs_modinit':
> trans_usbg.c:(.init.text+0x1e): undefined reference to `usb_function_register'
>
> Select the config for NET_9P_USBG to fix it.
>
> Fixes: a3be076dc174 ("net/9p/usbg: Add new usb gadget function transport")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> net/9p/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> index 63f988f0c9e8..ee967fd25312 100644
> --- a/net/9p/Kconfig
> +++ b/net/9p/Kconfig
> @@ -43,6 +43,8 @@ config NET_9P_XEN
> config NET_9P_USBG
> bool "9P USB Gadget Transport"
> depends on USB_GADGET=y || USB_GADGET=NET_9P
> + select CONFIGFS_FS
> + select USB_LIBCOMPOSITE
> help
> This builds support for a transport for 9pfs over
> usb gadget.
Fixed building on arm64.
Tested-by: Kexy Biscuit <kexybiscuit@aosc.io>
https://buildit.aosc.io/jobs/43382
--
Best Regards,
Kexy Biscuit
next prev parent reply other threads:[~2024-10-03 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 8:15 Jinjie Ruan
2024-10-03 17:37 ` Kexy Biscuit [this message]
2024-10-09 7:49 ` Jinjie Ruan
2024-10-09 7:55 ` Greg KH
2024-10-10 2:06 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1383f52-b1b3-4967-8bd1-abb42fedba4f@aosc.io \
--to=kexybiscuit@aosc.io \
--cc=aou@eecs.berkeley.edu \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=m.grzeschik@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ruanjinjie@huawei.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®