From: <Mario.Limonciello@dell.com>
To: <dvhart@infradead.org>
Cc: <andy.shevchenko@gmail.com>, <linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <stable@vger.kernel.org>
Subject: RE: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak
Date: Wed, 12 Sep 2018 12:14:34 +0000 [thread overview]
Message-ID: <d140b6171dfe4e748b7491f4955c07be@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <20180910205139.GC5659@wrath>
Darren,
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Monday, September 10, 2018 3:52 PM
> To: Limonciello, Mario
> Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org;
> stable@vger.kernel.org
> Subject: Re: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak
>
> On Mon, Sep 10, 2018 at 01:01:52PM -0500, Mario Limonciello wrote:
> > ACPI buffers were being allocated but never freed.
> >
> > Reported-by: Pinzhen Xu <pinzhen.xu@intel.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > Cc: stable@vger.kernel.org
>
> Thanks Mario and Pinzhen, both queued. That's an easy one to miss, the usage not
> being particularly obvious.
>
This cropped up and is fixed by that patch:
https://github.com/dell/libsmbios/issues/63
Given the impact and how small the patch is, I think it might be good if this can come to 4.19-rcX if possible.
Thoughts?
I suspect this one might be the same issue too:
https://bugzilla.redhat.com/show_bug.cgi?id=1627609
next prev parent reply other threads:[~2018-09-12 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 18:01 Mario Limonciello
2018-09-10 18:01 ` [PATCH 2/2] platform/x86: alienware-wmi: " Mario Limonciello
2018-09-10 20:51 ` [PATCH 1/2] platform/x86: dell-smbios-wmi: " Darren Hart
2018-09-12 12:14 ` Mario.Limonciello [this message]
2018-09-12 16:06 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d140b6171dfe4e748b7491f4955c07be@ausx13mpc120.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®