From: Jason Yan <yanaijie@huawei.com>
To: <gregkh@linuxfoundation.org>, <hariprasad.kelam@gmail.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Cc: Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'
Date: Mon, 27 Apr 2020 10:17:29 +0800 [thread overview]
Message-ID: <d141d9e7-5310-672a-9ffd-6be1b448261a@huawei.com> (raw)
In-Reply-To: <20200426094334.24346-1-yanaijie@huawei.com>
Sorry, it has already been fixed by YueHaibing. Please ignore this.
在 2020/4/26 17:43, Jason Yan 写道:
> Fix the following gcc warning:
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
> ‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
> struct registry_priv *pregistrypriv;
> ^~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 7853af53051d..e42d8c18e1ae 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)
>
> static void HalRxAggr8723BSdio(struct adapter *padapter)
> {
> - struct registry_priv *pregistrypriv;
> u8 valueDMATimeout;
> u8 valueDMAPageCount;
>
> -
> - pregistrypriv = &padapter->registrypriv;
> -
> valueDMATimeout = 0x06;
> valueDMAPageCount = 0x06;
>
>
prev parent reply other threads:[~2020-04-27 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 9:43 Jason Yan
2020-04-27 2:17 ` Jason Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d141d9e7-5310-672a-9ffd-6be1b448261a@huawei.com \
--to=yanaijie@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®