From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E3F43AE6F8 for ; Wed, 18 Mar 2026 09:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773825888; cv=none; b=bbjXpfrHndr3PmOrLS1oyvN/7/v4f/n2h+mguZCUSMSdNn+q0VfzLEn81FlorWKS3Q/yV7Sg0g7C9351A8PBFEV6gTR+s6PAaR9b9xVbB7cKMGQ+YMqgNSAAdNDb4038dJ/mBHOQG7IKQ4H8BRneOCj8P9BLawSH6kXoxZoFbvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773825888; c=relaxed/simple; bh=lQpBe9CcR4XYulE4lNgLbWzUt8xBy4TlZK/UmAmbEXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GqJDyjRrGZgrCxDPV2pkOCGUSUPlaW4fn45B3RI9bNitX4GixlQGY9Fno3nIw6RJAMPNXX5pghsyN8HQAmU7u1aPPsO3i5S5mtWkC+2jQwCO7nudRTitZzbNBf0n9wnAGSyBq1v+AlhTKEIKlL4qHetkH4JypFjajKNVtpNHB4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EqLgkoLe; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EqLgkoLe" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43b4f48c47cso1177857f8f.0 for ; Wed, 18 Mar 2026 02:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773825886; x=1774430686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rNKBTzUdX68mACaRpFmDLYY/h6NQejPTpn8KgeZ6DN4=; b=EqLgkoLemsCgfeTNsTwHyaTXgt2RPt5NFD0kgKhy33fFk5ZTtjj2PH52o1WvFz2NPx xTM88wjxWCER93c0/SywWuZZet8af4GT6yOl5XroDSptNhSrznEbYCTbyiLh1RYXqLC4 zdTFR9TyI9sLLEOpqEW3EC0LKlam4kHa81BfUEz7y1oTAdypM6x972EPv1awSt7S9Bus yIy934chiagspHTJN5HnfVkBGcBT84tZlOosu/es68QuAaKvnuEgyV0WcWdSC5nrsGm7 3pEly6/+fQXnUNvsQ1GaGbb4mN0JrhELhwZG4fSLlXny9VflO2vsMKEQie8NMj5ruLKA PW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773825886; x=1774430686; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rNKBTzUdX68mACaRpFmDLYY/h6NQejPTpn8KgeZ6DN4=; b=mpq1TthaU0to9HegxA+BMIz+E6yb8fDWRp7dw3t94+gGGTtuAV57pjNSD3OgY2YTe+ mfwTNsVvA55lGDxiwyK38yDeSKNLkXXualjKNyeyNG030e1S0hpyPCEKPFr/BFCoPtX8 zpD29CaCA3ock+IY6OkhvKX0HYyn+EYQWj5VibmELyBirUJf55IWWDl8k2EhpNL3z57F ZZwpllsEgxdAGIvGgl1U7aq5OfJUi41I3gO5ON0aVocBM/MOfjDaAyIPb6wOTSswq2L2 D//ZItf47FEM1/tRkngK+3/MsBGTL65RVzbrqYJgYvyjqqIudxHBXFRYfj6jAzKWgZDo YcbQ== X-Forwarded-Encrypted: i=1; AJvYcCXSKYnVZGt70ZQiqzdyB9T9sZ/SOLHcdoAOgR2isxfDODI/Nfk4c+jdtw6R7+DMmMsIRTEpTPtoY/RMRJs=@vger.kernel.org X-Gm-Message-State: AOJu0Yza++mng9Sq97Shwy8gTtBikW9kFvylsa5GCYuI58sfuy5w6BU+ VxTWCJQrof2syIunwqsnCfEmm55z5+ff6xmhfksu/eMdqTTPyqyQzyfuf23wS30WN+U= X-Gm-Gg: ATEYQzw/sGyrSNvuPDtG9npnOH6hvfHUcyAs78FBhYk9jVgThYgOhUSzBySWXRV90UF mHJnk8U6Wlv99634PAXkJD4/hRcfDaNuKgBR157iD4eH2S0BA6LiDDXoPBwLUND3L/WjYAzhTRR hrV2r79RiweqgW/Ocn7LFA67vIIy19IoXZ9WiGt90nXkFBwju08Jn6Q++xVTqKCnmj8hCskpxYh z0IS/Y33+vei7SH9sKKvUYM8oiN1YB+S5RkeHhLAOVPdwpovpt16p46gXOX5lQzd806rhoSopNW m7YTvt7E4RSghK/uCk+bXWhSY6ziXP2n1RWz+3Spu6J7+1092JffXvr3Sz1EBHJMmisM0x45sqF DkPukuPQPC9sgEX9SOuF7VSiJGBVK6IejGvJybzKWSODWwLsZeX4xvTPGlE8oeCbFYc1RJtYUZg cQD/1QRMrfYS4i2YUoe+zYfHUnz2k9J0t46qIdu3/8fDZwAZ1xOTfqnR/G X-Received: by 2002:a05:600c:83c5:b0:480:6bef:63a0 with SMTP id 5b1f17b1804b1-486f4456f1fmr40963985e9.21.1773825885802; Wed, 18 Mar 2026 02:24:45 -0700 (PDT) Received: from ?IPV6:2a07:de40:a101:3:ce70:3e6f:3b9c:9125? ([2a01:4a0:2e:ffff:ffff:ffff:ffff:ffff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51852097sm6495727f8f.9.2026.03.18.02.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 02:24:45 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 10:24:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] scsi: alua: Add scsi_alua_stpg_run() To: John Garry , Hannes Reinecke , martin.petersen@oracle.com, james.bottomley@hansenpartnership.com, bmarzins@redhat.com Cc: jmeneghi@redhat.com, linux-scsi@vger.kernel.org, michael.christie@oracle.com, snitzer@kernel.org, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260317120703.3702387-1-john.g.garry@oracle.com> <20260317120703.3702387-8-john.g.garry@oracle.com> <1bf4f9c3-7ab9-4be9-9061-0611a41242d3@suse.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/18/26 09:59, John Garry wrote: > On 18/03/2026 07:57, Hannes Reinecke wrote: >>> +static inline int scsi_alua_stpg_run(struct scsi_device *sdev, bool >>> optimize) >>> +{ >>> +    return 0; >>> +} >>>   static inline int scsi_alua_sdev_init(struct scsi_device *sdev) >>>   { >>>       return 0; >> >> No. STPG handling should be done in scsi_dh_alua _only_. We really >> should not attempt this in the scsi core. > > It's not so nice to have the functionality spread out. The way I see it > is that drivers/scsi/scsi_alua.c is mostly a library, but also has > functionality to "drive" ALUA for native SCSI multipathing. > > Anyway, can you confirm which of the following do you think from this > series should be in scsi_dh_alua.c: > > - scsi_alua_stpg_run() > - scsi_alua_stpg() > - submit_stpg() > > You already said scsi_alua_stpg_run() should be. > Gnaa. Misread that one (blame lack of coffee). stpg should be handled in scsi_dh_alua. Arguable we could move the utility functions (submit_stpg and maybe scsi_alua_stpg) in the core alua code, but scsi_alua_stpg_run() should be kept in scsi_dh_alua. If that makes sense ... Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich