mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Pfaff <tpfaff@pcs.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty: Remove pointless synchronize_irq() in uart_port_shutdown()
Date: Wed, 11 May 2022 09:48:47 +0200	[thread overview]
Message-ID: <d157042-39ed-7b56-a40-e0c6c1e3f3db@pcs.com> (raw)
In-Reply-To: <91c006d0-c6ff-71fa-f0c3-22cf1896fc02@kernel.org>



On Wed, 11 May 2022, Jiri Slaby wrote:

> On 10. 05. 22, 15:54, Thomas Pfaff wrote:
> > From: Thomas Pfaff <tpfaff@pcs.com>
> > 
> > Calling synchronize_irq() after free_irq() is pointless, the context to
> > the irq is already lost.
> > It was noticed while creating the bugfix "genirq: Synchronize interrupt
> > thread startup".
> 
> That's correct for most drivers. But some drivers don't call free_irq() in
> ->shutdown(). So you likely have to move the synchronization to them. By a
> quick grep, I found icom, jsm, sccnxp, sifive, sunhv, and sunzilog.
> 

Sorry, I did not check all the drivers.
Then I would keep it in serial_core, as it does not hurt anymore.

Thanks,
    Thomas



      reply	other threads:[~2022-05-11  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 13:54 Thomas Pfaff
2022-05-10 17:44 ` Thomas Gleixner
2022-05-11  6:21 ` Jiri Slaby
2022-05-11  7:48   ` Thomas Pfaff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d157042-39ed-7b56-a40-e0c6c1e3f3db@pcs.com \
    --to=tpfaff@pcs.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®