From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F69C433E6 for ; Tue, 26 Jan 2021 19:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7518D22B37 for ; Tue, 26 Jan 2021 19:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388973AbhAZFzl (ORCPT ); Tue, 26 Jan 2021 00:55:41 -0500 Received: from foss.arm.com ([217.140.110.172]:46654 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728087AbhAYM3Y (ORCPT ); Mon, 25 Jan 2021 07:29:24 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C32EED1; Mon, 25 Jan 2021 03:31:40 -0800 (PST) Received: from [10.37.8.33] (unknown [10.37.8.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25E963F66E; Mon, 25 Jan 2021 03:31:38 -0800 (PST) Subject: Re: [PATCH] kasan: export kasan_poison To: Arnd Bergmann , Andrey Ryabinin , Andrew Morton , Stephen Rothwell , Andrey Konovalov , Marco Elver , Alexander Potapenko Cc: Arnd Bergmann , Dmitry Vyukov , Walter Wu , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210125112831.2156212-1-arnd@kernel.org> From: Vincenzo Frascino Message-ID: Date: Mon, 25 Jan 2021 11:35:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210125112831.2156212-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/21 11:28 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The unit test module fails to build after adding a reference > to kasan_poison: > > ERROR: modpost: "kasan_poison" [lib/test_kasan.ko] undefined! > > Export this symbol to make it available to loadable modules. > > Fixes: b9b322c2bba9 ("kasan: add match-all tag tests") > Signed-off-by: Arnd Bergmann Thanks I just stumbled on the same issue ;) Reviewed-by: Vincenzo Frascino > --- > mm/kasan/shadow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index de6b3f074742..32e7a5c148e6 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -94,6 +94,7 @@ void kasan_poison(const void *address, size_t size, u8 value) > > __memset(shadow_start, value, shadow_end - shadow_start); > } > +EXPORT_SYMBOL_GPL(kasan_poison); > > void kasan_unpoison(const void *address, size_t size) > { > -- Regards, Vincenzo