From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED69726C3BE; Tue, 6 Jan 2026 07:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767685647; cv=none; b=sQHrUOBEtggtTdj34ZrzVBhFXBD2FDMYZGDR2TeeBxWnmx86Kr77rL0chhF/Qj8A/jmdx3/DPnGdvdYIo6jBAlVE/wR1uwLZAPr1BMqJ+/6x/1kCrb2FHiO6FEB/KORBGahA2ZayhUHj9naZy53TleFDN4b1wlzdemJznVkpBTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767685647; c=relaxed/simple; bh=JMy7HveBG/Hvay9PrFz8hIdQiHB0fgpsWfolz0ISj1o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BbH4IUkNpgz7OT5WdVBS8aGoHOEeF4iLHVIETGr49LDtxRm9aQWcvnO+mqNNSmFo+op+EcuGrPyAQp0ZydoFPTR/RonmPkr+0InbOyDnKetzAAW2SZUeWO4cRUlzJs0wvRcAgVlR/5qBoLLQKw+QnyhtycmOyriJq4DkcGtp3sM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BFohZBo/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BFohZBo/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27AC2C116C6; Tue, 6 Jan 2026 07:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767685646; bh=JMy7HveBG/Hvay9PrFz8hIdQiHB0fgpsWfolz0ISj1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BFohZBo/m+HGAjcrGa4q2BYVtAqyR3aWmHsvLwTIZYJez6uauneJpplO/2GcRW8Zb IUFAheOwJmym8/rSmODYMnSC5j2EdbP38CM6tcz9KoB9IRQ0EtxKByPiBs1f/04hfd K38a57wtg1q+BMKDaNK9ijMrEO1VBt74M15/JsQSEpE/dKodFpfgkAi/osDT1vFngg 2inxLFuVsumphUkHnnVgvjTxFQI//ci+N1XQiy4hhhERHSd3tPLdXDzS/9/3xhHFIW xB8Lnk5UtaaPluNRt4LzcssrPbi6UnUqbEfwvNOrGmFpj5fV1YwidJ/4aDsfZJ8QZW 86JgJXEGinYuQ== Message-ID: Date: Tue, 6 Jan 2026 08:47:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiDlm57lpI06IFtQQVRDSCB2MyAxLzJd?= =?UTF-8?Q?_dt-bindings=3A_arm=3A_cix=3A_add_OrangePi_6_Plus_board?= To: Gary Yang Cc: Peter Chen , Fugang Duan , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-cix-kernel-upstream@cixtech.com" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260104075400.1673101-1-gary.yang@cixtech.com> <20260104075400.1673101-2-gary.yang@cixtech.com> <20260105-excellent-uakari-of-joy-f0dfa4@quoll> <63454553-01df-4c40-aad3-7ea64bef685e@kernel.org> <33a70735-8058-4c2c-91f4-2a3ed0e0274d@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/01/2026 08:41, Gary Yang wrote: > Hi Krzysztof: > > Thanks for you commets > >> EXTERNAL EMAIL >> >> On 06/01/2026 05:52, Gary Yang wrote: >>> Hi Krzysztof: >>> >>> Thanks for your comments >>> >>>> EXTERNAL EMAIL >>>> >>>> On 05/01/2026 09:49, Gary Yang wrote: >>>>> Hi Krzysztof: >>>>> >>>>> Thanks for your comments >>>>> >>>>>> EXTERNAL EMAIL >>>>>> >>>>>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote: >>>>>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core >>>>>>> 64-bit processor + NPU processor,integrated graphics processor, >>>>>>> equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M >>>>>>> interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to >>>>>>> meet the needs of fast read/write and high-capacity storage >>>>>>> >>>>>>> Signed-off-by: Gary Yang >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++-- >>>>>>> 1 file changed, 9 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml >>>>>>> b/Documentation/devicetree/bindings/arm/cix.yaml >>>>>>> index 114dab4bc4d2..9e132e609b7b 100644 >>>>>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml >>>>>>> @@ -16,9 +16,16 @@ properties: >>>>>>> compatible: >>>>>>> oneOf: >>>>>>> >>>>>>> - - description: Radxa Orion O6 >>>>>>> + - description: Radxa Orion O6 board >>>>>>> items: >>>>>>> - - const: radxa,orion-o6 >>>>>>> + - enum: >>>>>>> + - radxa,orion-o6 >>>>>>> + - const: cix,sky1 >>>>>>> + >>>>>>> + - description: Xunlong orangepi 6 plus board >>>>>>> + items: >>>>>>> + - enum: >>>>>>> + - xunlong,orangepi-6-plus >>>>>> >>>>>> Previous patch was correct, not this one. >>>>>> >>>>>>
>>>>>> This is a friendly reminder during the review process. >>>>>> >>>>>> It looks like you received a tag and forgot to add it. >>>>>> >>>>>> If you do not know the process, here is a short explanation: >>>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >>>>>> versions of patchset, under or above your Signed-off-by tag, unless >>>>>> patch changed significantly (e.g. new properties added to the DT >>>>>> bindings). Tag is "received", when provided in a message replied to >>>>>> you on the mailing list. Tools like b4 can help here. However, >>>>>> there's no >>>> need to repost patches *only* to add the tags. >>>>>> The upstream maintainer will do that for tags received on the >>>>>> version they apply. >>>>>> >>>>>> Please read: >>>>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro >>>>>> ce >>>>>> ss/sub >>>>>> mitting-patches.rst#L577 >>>>>> >>>>>> If a tag was not added on purpose, please state why and what changed. >>>>>>
>>>>>> >>>>>> Read last sentence and linked documentation. Where did you explain >>>>>> ignoring/dropping my tag? >>>>>> >>>>> >>>>> Yes, the previous version was acked by you before. >>>> >>>> I stressed what I expect twice. In form letter and later explicitly. >>>> You still ignored it. >>>> >>>>> >>>>> When apply it, we found that orangepi 6 plus and Radxa Orion O6 >>>>> belongs >>>> the different boards. >>>>> >>>>> So we need to add a new item for it. Like these from qcom.yaml >>>>> >>>>> - description: Qualcomm Technologies, Inc. Distributed Unit >>>>> 1000 >>>> platform >>>>> items: >>>>> - enum: >>>>> - qcom,qdu1000-idp >>>>> - qcom,qdu1000-x100 >>>>> - const: qcom,qdu1000 >>>>> >>>>> - description: Qualcomm Technologies, Inc. Radio Unit 1000 >> platform >>>>> items: >>>>> - enum: >>>>> - qcom,qru1000-idp >>>>> - const: qcom,qru1000 >>>> >>>> No, look at SoCs. Different SocS. >>>> >>> >>> Please Look at rockchip.yaml, the same Socs, and the different boards >>> >>> - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition) >>> items: >>> - const: vamrs,ficus >>> - const: rockchip,rk3399 >>> >>> - description: 96boards RK3399 Rock960 (ROCK960 Consumer >> Edition) >>> items: >>> - const: vamrs,rock960 >>> - const: rockchip,rk3399 >>> >>> For the different boards，please give your professional >>> suggestions，Thanks a lot >> >> I gave you already. >> > > We find these codes below from qcom.yaml, Can we do the same things? Open your binding. How many SKUs you have? ZERO. Why do you ask if you can add more SKUs? To make the bindings fake? I already told you what you have to do and you completely ignored it. Previous code was correct, but you need to fix description. And look how Qualcomm or IMX organizes this file. I finished responding here, because you just don't bother to read my replies. Best regards, Krzysztof