mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Hui Peng <benquike@gmail.com>
Cc: dave@stgolabs.net, tglx@kernel.org, dvhart@infradead.org,
	peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] futex: fix hb lock mismatch in futex_wait_requeue_pi() and CLONE_VFORK hash init
Date: Mon, 21 Sep 2026 19:43:49 -0300	[thread overview]
Message-ID: <d162cde5-b53c-4e95-b587-6ee723c6783e@igalia.com> (raw)
In-Reply-To: <20260919221730.3707261-1-benquike@gmail.com>

Hi Hui Peng,

Em 19/09/2026 19:17, Hui Peng escreveu:
> Fix two issues in futex and fork initialization:
> 
> 1. In futex_wait_requeue_pi(), if futex_wait_queue() returns with

I see an outdated comment with futex_wait_queue(), but I don't think 
this function exists anymore.

>     q.lock_ptr updated tohb2's lock after a requeue timeout or signal
>     race, unlocking the original hb1 lock instead of q.lock_ptr leaves
>     hb2 locked and unlocks an unheld spinlock. Always unlock via
>     q.lock_ptr.
> 2. In copy_mm() (kernel/fork.c), initialize mm->futex_phash properly
>     when cloning so private futex hash state is consistent across
>     CLONE_VFORK.
> 

This part was already addressed:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b61b6f95d6722ddbbbd09e689fa41b55fd36f9a5

> Fixes: e5c6828493b5 ("futex: Split out requeue")
> Assisted-by: LLM

Please always double check in the current mainline code if the robots 
ideas are up to date.

> Signed-off-by: Hui Peng <benquike@gmail.com>

      reply	other threads:[~2026-09-21 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 22:17 Hui Peng
2026-09-21 22:43 ` André Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d162cde5-b53c-4e95-b587-6ee723c6783e@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=benquike@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®