mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <Eugen.Hristev@microchip.com>, <Nicolas.Ferre@microchip.com>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <Claudiu.Beznea@microchip.com>,
	<robh+dt@kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines
Date: Tue, 8 Mar 2022 08:21:23 +0000	[thread overview]
Message-ID: <d16673c8-3a19-fcbf-63d0-2d2090fc7318@microchip.com> (raw)
In-Reply-To: <20220307113827.2419331-1-eugen.hristev@microchip.com>

On 3/7/22 13:38, Eugen Hristev wrote:
> Flexcom3 is used as board console serial. There are no pull-ups on these
> lines on the board. This means that if a cable is not connected (that has
> pull-ups included), stray characters could appear on the console as the
> floating pins voltage levels are interpreted as incoming characters.
> To avoid this problem, enable the internal pull-ups on these lines.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 08685a10eda1d..dd047a8523907 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
>  	pinctrl_flx3_default: flx3_default {
>  		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
>  			 <PIN_PD17__FLEXCOM3_IO1>;
> -		bias-disable;
> +		bias-pull-up;
>  	};
>  
>  	pinctrl_flx4_default: flx4_default {


  reply	other threads:[~2022-03-08  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 11:38 Eugen Hristev
2022-03-08  8:21 ` Tudor.Ambarus [this message]
2022-04-13  8:38   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d16673c8-3a19-fcbf-63d0-2d2090fc7318@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®