From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Eugen Hristev <eugen.hristev@collabora.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v4 1/9] dt-bindings: arm: mediatek: Sort entries by SoC then board compatibles
Date: Mon, 22 Jan 2024 09:02:55 +0100 [thread overview]
Message-ID: <d16723a6-5602-4fa8-9cfc-589846b75f5b@gmail.com> (raw)
In-Reply-To: <20231213150435.4134390-2-wenst@chromium.org>
On 13/12/2023 16:04, Chen-Yu Tsai wrote:
> Some of the new MediaTek board entries were inserted in a chronological
> order, or just randomly. This makes it harder to search for an entry.
>
> Sort the entries by first grouping by SoC, then sorting by board
> compatible strings. Also add a comment at the top asking people to do
> the same.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Does not apply cleanly, would you mind to rebase the whole series onto v6.8-rc1.
Regards,
Matthias
> ---
> Changes since v3:
> - Collected reviewed-by from Angelo
> Changes since v2:
> - none
> Changes since v1:
> - Collected ack from Conor
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 123 +++++++++---------
> 1 file changed, 62 insertions(+), 61 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index a5999b3afc35..60337b439744 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -17,6 +17,7 @@ properties:
> const: '/'
> compatible:
> oneOf:
> + # Sort by SoC (last) compatible, then board compatible
> - items:
> - enum:
> - mediatek,mt2701-evb
> @@ -129,71 +130,10 @@ properties:
> - enum:
> - mediatek,mt8173-evb
> - const: mediatek,mt8173
> - - items:
> - - enum:
> - - mediatek,mt8183-evb
> - - const: mediatek,mt8183
> - - description: Google Hayato rev5
> - items:
> - - const: google,hayato-rev5-sku2
> - - const: google,hayato-sku2
> - - const: google,hayato
> - - const: mediatek,mt8192
> - - description: Google Hayato
> - items:
> - - const: google,hayato-rev1
> - - const: google,hayato
> - - const: mediatek,mt8192
> - - description: Google Spherion rev4 (Acer Chromebook 514)
> - items:
> - - const: google,spherion-rev4
> - - const: google,spherion
> - - const: mediatek,mt8192
> - - description: Google Spherion (Acer Chromebook 514)
> - items:
> - - const: google,spherion-rev3
> - - const: google,spherion-rev2
> - - const: google,spherion-rev1
> - - const: google,spherion-rev0
> - - const: google,spherion
> - - const: mediatek,mt8192
> - - description: Acer Tomato (Acer Chromebook Spin 513 CP513-2H)
> - items:
> - - enum:
> - - google,tomato-rev2
> - - google,tomato-rev1
> - - const: google,tomato
> - - const: mediatek,mt8195
> - - description: Acer Tomato rev3 - 4 (Acer Chromebook Spin 513 CP513-2H)
> - items:
> - - const: google,tomato-rev4
> - - const: google,tomato-rev3
> - - const: google,tomato
> - - const: mediatek,mt8195
> - - items:
> - - enum:
> - - mediatek,mt8186-evb
> - - const: mediatek,mt8186
> - - items:
> - - enum:
> - - mediatek,mt8192-evb
> - - const: mediatek,mt8192
> - - items:
> - - enum:
> - - mediatek,mt8195-demo
> - - mediatek,mt8195-evb
> - - const: mediatek,mt8195
> - description: Google Burnet (HP Chromebook x360 11MK G3 EE)
> items:
> - const: google,burnet
> - const: mediatek,mt8183
> - - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> - items:
> - - enum:
> - - google,krane-sku0
> - - google,krane-sku176
> - - const: google,krane
> - - const: mediatek,mt8183
> - description: Google Cozmo (Acer Chromebook 314)
> items:
> - const: google,cozmo
> @@ -244,6 +184,13 @@ properties:
> - google,kodama-sku32
> - const: google,kodama
> - const: mediatek,mt8183
> + - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> + items:
> + - enum:
> + - google,krane-sku0
> + - google,krane-sku176
> + - const: google,krane
> + - const: mediatek,mt8183
> - description: Google Willow (Acer Chromebook 311 C722/C722T)
> items:
> - enum:
> @@ -251,10 +198,64 @@ properties:
> - google,willow-sku1
> - const: google,willow
> - const: mediatek,mt8183
> + - items:
> + - enum:
> + - mediatek,mt8183-evb
> + - const: mediatek,mt8183
> - items:
> - enum:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> + - items:
> + - enum:
> + - mediatek,mt8186-evb
> + - const: mediatek,mt8186
> + - description: Google Hayato
> + items:
> + - const: google,hayato-rev1
> + - const: google,hayato
> + - const: mediatek,mt8192
> + - description: Google Hayato rev5
> + items:
> + - const: google,hayato-rev5-sku2
> + - const: google,hayato-sku2
> + - const: google,hayato
> + - const: mediatek,mt8192
> + - description: Google Spherion (Acer Chromebook 514)
> + items:
> + - const: google,spherion-rev3
> + - const: google,spherion-rev2
> + - const: google,spherion-rev1
> + - const: google,spherion-rev0
> + - const: google,spherion
> + - const: mediatek,mt8192
> + - description: Google Spherion rev4 (Acer Chromebook 514)
> + items:
> + - const: google,spherion-rev4
> + - const: google,spherion
> + - const: mediatek,mt8192
> + - items:
> + - enum:
> + - mediatek,mt8192-evb
> + - const: mediatek,mt8192
> + - description: Acer Tomato (Acer Chromebook Spin 513 CP513-2H)
> + items:
> + - enum:
> + - google,tomato-rev2
> + - google,tomato-rev1
> + - const: google,tomato
> + - const: mediatek,mt8195
> + - description: Acer Tomato rev3 - 4 (Acer Chromebook Spin 513 CP513-2H)
> + items:
> + - const: google,tomato-rev4
> + - const: google,tomato-rev3
> + - const: google,tomato
> + - const: mediatek,mt8195
> + - items:
> + - enum:
> + - mediatek,mt8195-demo
> + - mediatek,mt8195-evb
> + - const: mediatek,mt8195
> - items:
> - enum:
> - mediatek,mt8365-evk
next prev parent reply other threads:[~2024-01-22 8:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 15:04 [PATCH v4 0/9] arm64: dts: mediatek: Add MT8186 Corsola Chromebooks Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 1/9] dt-bindings: arm: mediatek: Sort entries by SoC then board compatibles Chen-Yu Tsai
2024-01-22 8:02 ` Matthias Brugger [this message]
2024-01-22 8:17 ` Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 2/9] dt-bindings: arm: mediatek: Add MT8186 Tentacruel / Tentacool Chromebooks Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 3/9] dt-bindings: arm: mediatek: Add MT8186 Steelix Chromebook Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 4/9] dt-bindings: arm: mediatek: Add MT8186 Rusty Chromebook Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 5/9] dt-bindings: arm: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 6/9] arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool Chen-Yu Tsai
2023-12-14 10:31 ` AngeloGioacchino Del Regno
2023-12-14 14:37 ` Chen-Yu Tsai
2024-01-19 13:19 ` AngeloGioacchino Del Regno
2024-01-22 3:14 ` Chen-Yu Tsai
2023-12-14 10:39 ` Fei Shao
2024-01-01 14:09 ` Eugen Hristev
2024-01-02 10:25 ` Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 7/9] arm64: dts: mediatek: Introduce MT8186 Steelix Chen-Yu Tsai
2023-12-14 10:34 ` AngeloGioacchino Del Regno
2023-12-14 14:53 ` Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 8/9] arm64: dts: mediatek: Add MT8186 Steelix platform based Rusty Chen-Yu Tsai
2023-12-13 15:04 ` [PATCH v4 9/9] arm64: dts: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d16723a6-5602-4fa8-9cfc-589846b75f5b@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®