mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Gianluca Boiano <morf3089@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, "Wang, Sen" <sen@ti.com>,
	Markus Elfring <Markus.Elfring@web.de>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] ASoC: codecs: add Texas Instruments TAS2557 smart amplifier driver
Date: Fri, 20 Nov 2026 16:14:25 +0100	[thread overview]
Message-ID: <d1694124-558e-455e-b4ce-10363ede09ba@ixit.cz> (raw)
In-Reply-To: <20261120004414.1686884-1-morf3089@gmail.com>

On 20/11/2026 01:43, Gianluca Boiano wrote:
> The TAS2557 is a mono Class-D smart amplifier with an on-chip DSP for
> speaker protection, controlled over I2C, with audio over I2S/TDM. The
> DSP needs a firmware image tuned for the speaker; without it the chip
> passes no audio.
> 
> Patch 1 adds the binding, patch 2 the driver. One node describes one
> chip or a stereo pair on one bus, using the reg-array convention of
> ti,tas2781.yaml: reg index 0 is DEV_A, index 1 is DEV_B.
> 
> v4 uses tas2781-comlib for register access, adds the firmware rate
> constraint asked for in the v2 review, and addresses the v3 review
> from Mark Brown, Krzysztof Kozlowski and Markus Elfring. The
> ti,imon-slot-nos/ti,vmon-slot-nos properties are gone: the register
> they were written to only holds the I-sense scale. I/V sense now stays
> on while the amplifier plays, as in TI's driver. Details are in the
> per-patch changelogs.
> 
> Testing: built against broonie/sound for-next with W=1, checkpatch
> --strict and dt_binding_check clean. The v4 driver was run in mono on
> a Xiaomi Redmi Note 6 Pro (SDM636, ASI2) on a 7.2-based kernel:
> firmware load, playback, stream restarts without a program reload and
> unbind/bind. Stereo pairs, TDM, DSP_A, ASI1 and suspend were not
> tested with v4.

Thank you for working on this. We have mutiple use-cases in sdm845, please let 
me and possibly phone-devel@vger.kernel.org in CC.

I may sent tas2559 a top of your patch at some point, thou I think it has some 
cleaning ahead first :)

David

> 
> Link to v3: https://lore.kernel.org/linux-sound/20260717233402.414326-1-morf3089@gmail.com/
> Link to v2: https://lore.kernel.org/linux-sound/20260711145722.188556-1-morf3089@gmail.com/
> Link to v1: https://lore.kernel.org/linux-sound/20260709221331.989109-1-morf3089@gmail.com/
> 
> Gianluca Boiano (2):
>    ASoC: dt-bindings: add Texas Instruments TAS2557
>    ASoC: codecs: add TAS2557 mono smart amplifier driver
> 
>   .../devicetree/bindings/sound/ti,tas2557.yaml |  158 +
>   MAINTAINERS                                   |    1 +
>   sound/soc/codecs/Kconfig                      |   13 +
>   sound/soc/codecs/Makefile                     |    2 +
>   sound/soc/codecs/tas2557.c                    | 2973 +++++++++++++++++
>   sound/soc/codecs/tas2557.h                    |  207 ++
>   6 files changed, 3354 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2557.yaml
>   create mode 100644 sound/soc/codecs/tas2557.c
>   create mode 100644 sound/soc/codecs/tas2557.h
> 
> 
> base-commit: cee03387d20bb267663085d9ac2622ff9263d302


      parent reply	other threads:[~2026-11-20 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  0:43 Gianluca Boiano
2026-11-20  0:43 ` [PATCH v4 1/2] ASoC: dt-bindings: add Texas Instruments TAS2557 Gianluca Boiano
2026-11-20  0:43 ` [PATCH v4 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Gianluca Boiano
2026-11-20 15:14 ` David Heidelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1694124-558e-455e-b4ce-10363ede09ba@ixit.cz \
    --to=david@ixit.cz \
    --cc=Markus.Elfring@web.de \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=morf3089@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®