From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] spi: mpc5xxx-psc: Fix compile error
Date: Mon, 13 Mar 2023 08:41:43 +0100 [thread overview]
Message-ID: <d173d6d2-b9e6-b385-4685-301fc15e2675@kernel.org> (raw)
In-Reply-To: <20230312133959.256855-1-andi.shyti@kernel.org>
On 12/03/2023 14:39, Andi Shyti wrote:
> Commit 9e21720a4958 ("spi: mpc5xxx-psc: use
> devm_clk_get_enabled() for core clock") has made use of the
> devm_clk_get_enabled(), but it actually forgot to remove a couple
> of goto's, triggering the following compile error:
>
> drivers/spi/spi-mpc512x-psc.c: In function ‘mpc512x_psc_spi_of_probe’:
> drivers/spi/spi-mpc512x-psc.c:518:17: error: label ‘free_ipg_clock’ used but not defined
> 518 | goto free_ipg_clock;
>
> Replace those goto's with actual returns.
https://lore.kernel.org/all/20230310111544.57342-1-andriy.shevchenko@linux.intel.com/
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-13 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 13:39 Andi Shyti
2023-03-13 7:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d173d6d2-b9e6-b385-4685-301fc15e2675@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®