From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Lars Persson <lars.persson@axis.com>,
"David S. Miller" <davem@davemloft.net>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Srujana Challa <schalla@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>
Cc: linux-crypto@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com
Subject: Re: [PATCH 3/6] crypto: artpec6 - Simplify with of_device_get_match_data()
Date: Thu, 6 Nov 2025 20:09:49 +0100 [thread overview]
Message-ID: <d17ad0cf-eea1-4d72-8b02-2f8172ece8c6@linaro.org> (raw)
In-Reply-To: <20251106-crypto-of-match-v1-3-36b26cd35cff@linaro.org>
On 06/11/2025 17:31, Krzysztof Kozlowski wrote:
> struct device *dev = &pdev->dev;
> @@ -2853,12 +2852,10 @@ static int artpec6_crypto_probe(struct platform_device *pdev)
> if (artpec6_crypto_dev)
> return -ENODEV;
>
> - match = of_match_node(artpec6_crypto_of_match, dev->of_node);
> - if (!match)
> + variant = of_device_get_match_data(dev);
This needs cast for 32-bit builds like it was before. I will send v2.
> + if (!variant)
> return -EINVAL;
>
> - variant = (enum artpec6_crypto_variant)match->data;
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-06 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:31 [PATCH 0/6] crypto/hwrng: " Krzysztof Kozlowski
2025-11-06 16:31 ` [PATCH 1/6] hwrng: bcm2835 - Move MODULE_DEVICE_TABLE() to table definition Krzysztof Kozlowski
2025-11-06 20:34 ` Florian Fainelli
2025-11-06 16:31 ` [PATCH 2/6] hwrng: bcm2835 - Simplify with of_device_get_match_data() Krzysztof Kozlowski
2025-11-06 20:44 ` Florian Fainelli
2025-11-06 16:31 ` [PATCH 3/6] crypto: artpec6 " Krzysztof Kozlowski
2025-11-06 19:09 ` Krzysztof Kozlowski [this message]
2025-11-06 16:31 ` [PATCH 4/6] crypto: ccp - Constify 'dev_vdata' member Krzysztof Kozlowski
2025-11-06 20:48 ` Tom Lendacky
2025-11-06 16:31 ` [PATCH 5/6] crypto: ccp - Simplify with of_device_get_match_data() Krzysztof Kozlowski
2025-11-06 20:49 ` Tom Lendacky
2025-11-06 16:31 ` [PATCH 6/6] crypto: cesa " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17ad0cf-eea1-4d72-8b02-2f8172ece8c6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bbhushan2@marvell.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=florian.fainelli@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesper.nilsson@axis.com \
--cc=john.allen@amd.com \
--cc=lars.persson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=olivia@selenic.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=schalla@marvell.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®