From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D49D3F2101; Wed, 20 May 2026 15:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290860; cv=none; b=fqUOZIYuSAQsrvob7kb8yi+vghOaF+oN+PaWbXDo6Dhf7LyGd7NtkV8pvFGxXNp8BQaLRDDex/y+kUhUzhD/KLhYooimDvqm8kYucvCQpnlcUrKYk7T0EJxjGHy7oBTHlGbWvUIiNKqcPO9SGctMU3rFEo31mjslJ/tCg4Flzvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290860; c=relaxed/simple; bh=/dicLWyiTLIqJjMDqVvLE8H2Gl4zdK09ndu9K0HRk/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iyi6dutbvBWUxcOjwKm3Y6ifoLDuBpRht+x+kLQwJdo+RlQDBIsNoRpI2utPmpSC4zl7TcsfBbYQPsf/NIshqJXbVfanLroZ7tNg2IYDJkbI/rtvFxIkKaNk9erh+4PSPpIwZUj3l2Jgk1LanQ4evEi4qJYdqQbfo9jyxVzlZxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=t4lJ0fky; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="t4lJ0fky" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JQPeBgT0x9f1XP/QHtccMLVQq0iA+4UUdcKuFEPxVD8=; b=t4lJ0fkyVyt32Heo44vAc5XaPm tpjHmCfftDGnV0rv5zSDtHevhfxIPkn9+UtOKgFpzmsjhFoZW+KTy23OO+zT6hVOm9vy4ZF/1G0dx fDJhlw+wNunGt8ZjFeU9cA0AcECVJAaAVsnVKbN71WNvNKZ3iLWLHSTSrI235cm3OsOo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wPipW-003r3S-Nc; Wed, 20 May 2026 17:27:30 +0200 Date: Wed, 20 May 2026 17:27:30 +0200 From: Andrew Lunn To: Ciprian Regus Cc: selvamani.rajagopal@onsemi.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, parthiban.veerasooran@microchip.com Subject: Re: [PATCH net 1/2] net: ethernet: oa_tc6: Interrupt is active low, level triggered. Message-ID: References: <20260520151621.405125-1-ciprian.regus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520151621.405125-1-ciprian.regus@analog.com> On Wed, May 20, 2026 at 06:16:21PM +0300, Ciprian Regus wrote: > > ret = devm_request_irq(&tc6->spi->dev, tc6->spi->irq, oa_tc6_macphy_isr, > >- IRQF_TRIGGER_FALLING, dev_name(&tc6->spi->dev), > >+ IRQF_TRIGGER_LOW, dev_name(&tc6->spi->dev), > > tc6); > > oa_tc6_macphy_isr() doesn't clear the interrupt condition Since this is an SPI device, there is no way it can clear the condition, that needs a blocking operation. > devm_request_threaded_irq(..., IRQF_TRIGGER_LOW | IRQF_ONESHOT, ...) > > (together with some rework to call oa_tc6_try_spi_transfer() from the > threaded irq part). Threaded makes sense. Not so sure about ONESHOT. We need it to fire again when the thread handler exists and the condition is still true. Andrew