From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732DA201036 for ; Thu, 9 Jan 2025 07:43:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736408623; cv=none; b=gnWzavWEzuD6WSEIXId+xeFMoUbtNhSFAndAoUjmAw5Wd4oV9MdFWONNghFf7JDEAfXHBJsOnogS33Z/IEjT6OC3t5DS/J9Pg20/6UjczfLwuN8oIxEyXD2eis/xAxNf12p6Ju6XAa6vHdOxPH/lkaCama2J5EZtOoreDSktxq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736408623; c=relaxed/simple; bh=o8I4CKv2t24jZedmnbTtU4Gs3sA5LsC+rd6Kogi6hbk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Er2YQ7fx9bJWKSImTbWFhlZS8LBRWb1BnILCJlPAaIxzSv+fBfgOX7su+9azOAM8x4Ac6y3APEr9Bv5uztHGlxzuJhhh+YhyIALpJBM0BKNyjOZu8z2+FGquQ9c8zLhPlBEGybZzBrzRHdS3XBISza4OrjUKsTWYn4N3MNiffMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OP8vYveA; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OP8vYveA" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3862d6d5765so297826f8f.3 for ; Wed, 08 Jan 2025 23:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736408620; x=1737013420; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jh+wwxjIWe7Gi85zIpTYnZ3FRcd2JxnVHEsCva5iTpU=; b=OP8vYveAoa/8gjR/kYFZsz7nj2bHm83FhxGZQ2aICYAJ71ANIu2P2zcI01lCdiRe5n yz7Pv4+pBdYcTAzwg721iC7lMXamyG2DIse+gbh8xJjMD99ST2sRbPO9irYRe0kquObT OGfviazlOxRqwS+a+MNkatYSoWU0ERABnOTihweiJlm/TvPAGuixyTWNEYlfMQ52vLZr h2cBaYiz5CeAOGsmO5P3N7xsLx+DVJcH+vTvJVRnel5KHuLaJaQHoV8RliZSDAsNBig9 Va7Is9ORUeRdJSiNHzuVQSgMHM3nI+hKHIi7Tvg2a7MSJpb6Bz14Uu5wk5K6ZEFE0cKi ITuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736408620; x=1737013420; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jh+wwxjIWe7Gi85zIpTYnZ3FRcd2JxnVHEsCva5iTpU=; b=Yoh5NgIUEmB0PZp5EvahLn+Ygjx4Vi9OVJXS6sU6V/Glzg6EsfUlBVrxrBXmXmt6CU 8GUcd8aEryy0iIt3HYrTO/x/YZG7El9qDMy8aEq+i10lFL8YK8X01BggFCj6AFt4aLWR wmwrXDZbe5uhDR4yTVhE4MF+6qbKdkXEugnickuNvm/p7fJkQALQIwOpqEPP3M+FN2l5 57vcFlWQUSl1upul3/4tYI7PZEfvfU/TmqQBvsqYechjgHOXCrjGCd7t+8GX6EYmtDm1 IhrjmtCVnUSCNemr/4reXWfoQfc62n+Z0Blk+Re3ucvCQaH8EHOjsEB6kbG0zuUZyGEG Ci9Q== X-Forwarded-Encrypted: i=1; AJvYcCVS5HMxZYb/N0UyJaL+n/uJK/WpqO3BLL4wpDzrwPW5y/CRlilC5t1NspdJPmp+COqPc/9a9rGukmmQ2Ow=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq4r8XRqUuSm7fjs07b8pXE1yHOk//0I6x4nRGNuMeNYwJgYQ5 hrjcXDKD5mxlFodbuyqJ5jTVtm51heNYN6u+Y0GeF5cnUO9ecge2+cTViJwJqS0= X-Gm-Gg: ASbGncvnk/3qsrK2kyTRo7o4yc0qP4grLxXyldyOTCbvDWHVoc+EYqsPyNxPZ7P7KRU TfMWP7XyuNzRcpqK3W98jWnvvw0Fh7/SA4uHg59iOf3Pl82NW519lU2dDQjx1IT4XOvEE5t4Lnx ouO9JFFJ/CD6d3ACKtXFGcbzMEwKIuUpactO3vsvMXVBEYGtFLr3YiJmA8vOajIwWZ4ALYTE3nR 8FMsvwJffZsjMuDs1O5LHH3WUwhut+a0p2d+LrkOHkAm2lDsBzdqncwHYBBpg== X-Google-Smtp-Source: AGHT+IG9Emr+GDLnC8gqqwHA+S34356wIMM4OfWPXphI8Xzji2jA9fchokaaaeT7GvxQmyRqyXJn3w== X-Received: by 2002:adf:9b99:0:b0:38a:6929:ff9e with SMTP id ffacd0b85a97d-38a872d2bbemr3513005f8f.7.1736408619837; Wed, 08 Jan 2025 23:43:39 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c7aesm1036006f8f.53.2025.01.08.23.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 23:43:38 -0800 (PST) Date: Thu, 9 Jan 2025 10:43:35 +0300 From: Dan Carpenter To: Sandeep Salwan Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gpib: Remove commented-out line entirely (v2) Message-ID: References: <20250108211127.13963-1-salwansandeep5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250108211127.13963-1-salwansandeep5@gmail.com> On Wed, Jan 08, 2025 at 04:11:27PM -0500, Sandeep Salwan wrote: > Per Greg’s feedback, remove the line instead of leaving it as a comment. > It's not needed for debugging, so let's delete it completely. Thanks. This isn't how we typically write commit messages. Instead say: This code has some debug code which is commented out. Delete it. > > Signed-off-by: Sandeep Salwan There is a specific formula for v2 patches: https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ > --- > drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > index 3cd01613d067..7ba968e24add 100644 > --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > @@ -31,10 +31,6 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt > int i, num_fifo_bytes; > //hardware doesn't support checking for end-of-string character when using fifo > if (tms_priv->eos_flags & REOS) { > - /* > - * pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags, > - * tms_priv->eos); > - */ > return tms9914_read(board, tms_priv, buffer, length, end, bytes_read); > } Now that you have deleted the commented out code, the curly braces need to be deleted as well. You don't need to mention this in the commit message. It is obvious and assumed. Please send a v3 of this patch. regards, dan carpenter