From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C08C77B73 for ; Fri, 26 May 2023 13:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243544AbjEZNMr (ORCPT ); Fri, 26 May 2023 09:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237174AbjEZNMo (ORCPT ); Fri, 26 May 2023 09:12:44 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B341D119 for ; Fri, 26 May 2023 06:12:42 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QSQHp3FSNzLnkw; Fri, 26 May 2023 21:09:42 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 21:12:39 +0800 Message-ID: Date: Fri, 26 May 2023 21:12:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] arm64: acpi: Export symbol for acpi_os_ioremap To: Ard Biesheuvel , Lorenzo Pieralisi CC: , , , , , , , , , References: <20230526121751.41060-1-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/5/26 20:39, Ard Biesheuvel 写道: > (cc Lorenzo) > > On Fri, 26 May 2023 at 14:20, Huisong Li wrote: >> The driver who calls the acpi_os_ioremap() cannot be compiled if the 'M' >> is selected for the driver. The compiling log is as follows: >> --> >> MODPOST Module.symvers >> ERROR: modpost: "acpi_os_ioremap" [drivers/soc/hisilicon/xxx.ko] undefined! >> scripts/Makefile.modpost:136: recipe for target 'Module.symvers' failed >> make[1]: *** [Module.symvers] Error 1 >> >> So this patch exports symbol for acpi_os_ioremap. >> > That driver does not exist in mainline. We have an uploading driver [1] that may use it. [1] https://patchwork.kernel.org/project/linux-soc/patch/20230522072211.8894-2-lihuisong@huawei.com/ > > Why does it need to use acpi_os_ioremap() instead of the ordinary > memremap/ioremap routines? This driver needs to ioremap the shared memory space of a PCC subspace. And @Sudeep suggested that we use this interface. It is suitable here. > >> Signed-off-by: Huisong Li >> --- >> arch/arm64/kernel/acpi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c >> index dba8fcec7f33..ec0414caf3d1 100644 >> --- a/arch/arm64/kernel/acpi.c >> +++ b/arch/arm64/kernel/acpi.c >> @@ -354,6 +354,7 @@ void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) >> } >> return ioremap_prot(phys, size, pgprot_val(prot)); >> } >> +EXPORT_SYMBOL(acpi_os_ioremap); >> >> /* >> * Claim Synchronous External Aborts as a firmware first notification. >> -- >> 2.33.0 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > .