From: Mark Brown <broonie@kernel.org>
To: Witold Sadowski <wsadowski@marvell.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
pthombar@cadence.com
Subject: Re: [PATCH v10 4/9] spi: cadence: Add Marvell SDMA operations
Date: Wed, 10 Jul 2024 18:28:01 +0100 [thread overview]
Message-ID: <d1877cb1-fe64-4cd0-913e-b9192edbd17f@sirena.org.uk> (raw)
In-Reply-To: <20240709221211.2130456-5-wsadowski@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
On Tue, Jul 09, 2024 at 03:12:06PM -0700, Witold Sadowski wrote:
> In Marvell xSPI implementation any access to SDMA register will result
> in 8 byte SPI data transfer. Reading less data(eg. 1B) will result in
> losing remaining bytes. To avoid that read/write 8 bytes into temporary
> buffer, and read/write whole temporary buffer into SDMA.
This breaks an x86 allmodconfig build:
/build/stage/linux/drivers/spi/spi-cadence-xspi.c: In function ‘m_ioreadq’:
/build/stage/linux/drivers/spi/spi-cadence-xspi.c:524:17: error: implicit declar
ation of function ‘ioread64_rep’; did you mean ‘ioread32_rep’? [-Werror=implicit
-function-declaration]
524 | ioread64_rep(addr, buf, full_ops);
| ^~~~~~~~~~~~
| ioread32_rep
/build/stage/linux/drivers/spi/spi-cadence-xspi.c: In function ‘m_iowriteq’:
/build/stage/linux/drivers/spi/spi-cadence-xspi.c:544:17: error: implicit declar
ation of function ‘iowrite64_rep’; did you mean ‘iowrite32_rep’? [-Werror=implic
it-function-declaration]
544 | iowrite64_rep(addr, buf, full_ops);
| ^~~~~~~~~~~~~
| iowrite32_rep
cc1: all warnings being treated as errors
(and there were some issues from 0day, didn't check if they were the
same.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-07-10 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 22:12 [PATCH v10 0/9] Marvell HW overlay support for Cadence xSPI Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 1/9] spi: dt-bindings: cadence: Add Marvell overlay bindings documentation for Cadence XSPI Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 2/9] spi: cadence: Add static PHY configuration in Marvell overlay Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 3/9] spi: cadence: Add clock configuration for Marvell xSPI overlay Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 4/9] spi: cadence: Add Marvell SDMA operations Witold Sadowski
2024-07-10 17:28 ` Mark Brown [this message]
2024-07-09 22:12 ` [PATCH v10 5/9] spi: cadence: Add Marvell xSPI interrupt changes Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 6/9] spi: cadence: Add Marvell xfer operation support Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 7/9] spi: cadence: Change resource mapping Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 8/9] spi: cadence: Change cs property reading Witold Sadowski
2024-07-09 22:12 ` [PATCH v10 9/9] spi: cadence: Try to read spi-tx/rx-bus width property using ACPI Witold Sadowski
2024-07-29 18:02 ` [PATCH v10 0/9] Marvell HW overlay support for Cadence xSPI Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1877cb1-fe64-4cd0-913e-b9192edbd17f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
--cc=wsadowski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®