From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33D53BFE4C for ; Wed, 17 Jun 2026 09:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781688975; cv=none; b=gIOt+zHTs7kr9Ch7APXm5Twgl5PYfYKOyO5FKzIJnAN6GAmOitgEq0DlBrVaYZSzqgEwu6fGZRBUqc1iUd22wREddciffcwhe8BpB4vKJ1Zug51RXaCPDTOFY0O2FHv3BkzQmBpK3kDGs2Sz7EU8qnLsM3S00PvXALrXc0WfrC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781688975; c=relaxed/simple; bh=KoyZoqsPBxWPy/4iTNAsylGppczE0drH2mLYNvgy0HM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kStLmTBuqnGZ1oflWT6BwVGUq+QP0yIgZTcqN5RP8eYBQddOmi9nlZUqGCV9dZGZj/vt9rhO7UsH2vRIjHVDx1vanR1fNGTGUYrRqgux36ZaDaNbGJmt5nlzYxsjCtys9GwNsfkGYRmKt8kc2HVYBrFq06l5gSJX4VKnB5JC2RY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A9bqtpE4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GXkM6glQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A9bqtpE4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GXkM6glQ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65H8UYnf2217728 for ; Wed, 17 Jun 2026 09:36:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z+wzvyO/iS1rj9mimdNrmwOL6jZPX/NqqiEkBWidZ3s=; b=A9bqtpE4sE5S4l8t 9n2rpYKezHAmtchlrueMWbiaIVb6amRHiY4iXTkfVzYu171GrjbJN/amwXhgbXlx ybBMMszyb2ZlCIst3zRmLU4UCcxBb6yPpa38juUZSxGtSJjEqR03vL8UbXpXSQpF W7Q2EPsUbWAydJcseQFjKn1LiWuBn9X4x55ve53Mk3WM/5TyHPxsdXMomUNmCI7W mZZ+Ek46VQXgz3GQufxryZzKx2hfSNTltP16U2My3osOtzWbcuojruFMwsz5p9zO 9yvWYBGm7JskRX9/rVYNA+bu1Bju4kI6jvh0kAZLpnYJaomafQ2qo8DBHhwAX9Au s3Hbag== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueeragpe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 09:36:12 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-915ccc2d4d2so118353285a.1 for ; Wed, 17 Jun 2026 02:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781688972; x=1782293772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z+wzvyO/iS1rj9mimdNrmwOL6jZPX/NqqiEkBWidZ3s=; b=GXkM6glQdbgArW7b1Pl9ZHsW7/0ZzHiw1ARuPeMgdGcsKXx6sxuJLAqrnudwWW2HIP xMp5m8j3/0EVqm7m/YsFC3qW/xkr5N5lAbp07jdetA0BGHl+mPP1OTnTvb5xKWwhDcd9 uHhq59X5ulw6kqCDYP4z6PzAIiNhkNYSut+rdotMZd6iJPe+tyuxwX3Hf9eh8gU/Urx5 m+iF9HO0MxpnUaktlA5coqJU8XkvDtIiFvvFjuCeiNY4kvgzfTGiLyBgWQylqKoggKXk EH9EngBUkx57nfv8xbC0NMaLnrsoxu8cjeWKFNLbj1vD+kVcRYtuwDjVmbEQeR4II6az jxXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781688972; x=1782293772; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z+wzvyO/iS1rj9mimdNrmwOL6jZPX/NqqiEkBWidZ3s=; b=JZEwaGZhiddR53xZrCgpkO3+bdwiiY7HiYouHPFcWolG6kbavjxQCmxmEFX0ptekOC UQpmou/YhwEHx41bFPAn08JhI6Cv2/PhViuREc8vV0Cyxc+AFToI3uDLNaEwUkefA4Rw R65ctILSzO6drbhYLCdMLkm5DHyzckBVlKO6SRSPFFA8c9UbBvc7q3egjVQSf6IQWMsE 5ODs7sZfOE2+hp4q/eHdVtdYkQ9u3ymI/ZA1if++1et3dtP8/O6jC5Y3bp6/fufgnDhY 1MmaTa903MZLRpfCCQEWPjn0cup/U4TPeWz7Mzp9IP/tew7rLXLJmdJiud2k7B9ueN2x jb2w== X-Forwarded-Encrypted: i=1; AFNElJ9234fl0vcehnMWAHtV7Vw2Kq6mWK4NN7yWvvUhAPJFKvw0ZOwsxuSR29aMutnKROH++f+Y4NLd+fSQOgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwNN3HS6WYQV8HdBS37tKNKOEvRc86BGU2bfyXBmGNNfbjZSFp7 da2IkTuGSRHrY1drdxTynmpJcfo/SZC9rRTo6gvDvOiZ3L2eghJNCfKJQm0HyOUQlbO5IKjjx1a sg3rOzI4/jGl5QRsgaeAm/JphYvlnOSd9ekA/eQJuD/aFvD81l8uUnnkdwmjBcfJi8oE= X-Gm-Gg: Acq92OH4CC/xcpVsvEgU1fdEZ19dF/Kno1bCn3ZfCBOzPhd4xHX2+aMEGhorBrMifS5 H8MxlAyq18ALIOsFW5vogazt+Y8UHDaJlO8DbPM24U52nWVYM03JVxjBkcFsE9VO84NtBX5CT6B L/aBUNkQFi7k2Pq7mZNBvIHtPC4hJ9HvbNDog/M0wmhY607z8afXF6+jI39eL8BKJTNzwiXheKn fsHBcvgDJstRayY7Ok4VFnqWWCWxqzLbyUhGutSJLZRcGwgAlzdwpwywkbJOJM4SX91Q8lNrVDe 9Imw5a62sHs7zazjJJMwhkj6ONSZPMi4ECxfdo8i4/myJXumM3R4FJ0XTjv8FvkSSi6Bxu0hM64 aPMwN6c+MAQQDPyQ1XbU55Tj/uNie4xeaAJM= X-Received: by 2002:a05:620a:4449:b0:915:8055:3f9f with SMTP id af79cd13be357-91d8b7b1dd8mr312772685a.6.1781688971925; Wed, 17 Jun 2026 02:36:11 -0700 (PDT) X-Received: by 2002:a05:620a:4449:b0:915:8055:3f9f with SMTP id af79cd13be357-91d8b7b1dd8mr312771085a.6.1781688971503; Wed, 17 Jun 2026 02:36:11 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8e1db3esm763237066b.56.2026.06.17.02.36.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 02:36:10 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 11:36:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bus: qcom-ebi2: unwind clocks on child setup failures To: Pengpeng Hou , Bjorn Andersson Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260616151703.23572-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616151703.23572-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDA4OSBTYWx0ZWRfX/p0FSFDQ9lA7 JuYa0JV8rZJr5W+ufcxlx5LXQZCqB4iNkSDKm+o9WiM7ZObGmlAnOO7JT6PmXT/svcIFiRt4VYY z8VnD/n+i3tHh4buGWedNV9s7MmdIkg= X-Proofpoint-GUID: bljmk6qOW4O0xHjS97fIphWPvmLwhhML X-Authority-Analysis: v=2.4 cv=d4fFDxjE c=1 sm=1 tr=0 ts=6a326a8c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=okfOTpmm0OxlZ874JiMA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDA4OSBTYWx0ZWRfXwEadNkBRv/lU MtRv1eVE+6lb3kAHJwBEKtmTfWj/faxksyaXaSkpy/VDtqNzxiY3g80kje6tc1WDGdLUAHun8Ue Rf8+rOwLj9wC7iB0M2gE6V3Q1bCk0EU1NZDNorXj3Y1l1VWTn/zsBFszUUnsVAKHUZuSdnxJnfm a9Cd6/jeVaxMbvKn4DfKnrowZsJjrKYsIGxpFoRk3ZruGhJqBzklQsZUZrlsevDazD22ZvhCil7 YP6GAa+9iYjbvQBvv3FBXba0v9jgF5kQS8pnE4hxnGRCPAEneLX3RTRlSfzrKLPWevnhkl1qvh/ hNTvVHCbJ+koCs6erZbMkO1TScFsSbml42mQQxSCjnfhSkqm+/iL3/kvGL4vJ8yckigZOGiTeYd vxj2mYj4d8qNUdMjqlwqlklsAEjZI1gu8eCsIPfXJXMmEa8qEa6zDNOUQHDCh1qjQ0Fxnt/kNjy rjs4M5+Q1+HiRENO0wQ== X-Proofpoint-ORIG-GUID: bljmk6qOW4O0xHjS97fIphWPvmLwhhML X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_01,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170089 On 6/16/26 5:17 PM, Pengpeng Hou wrote: > qcom_ebi2_probe() enables both EBI2 clocks before walking child > chip-select nodes. A missing child reg property returns directly from > that loop, bypassing the existing clock-disable labels. > > Route that failure through the existing unwind path. Also check the > final child population result, depopulate any partially created children, > and disable the clocks if population fails. > > Signed-off-by: Pengpeng Hou > --- > drivers/bus/qcom-ebi2.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c > index be8166565e7c..68fe931d1636 100644 > --- a/drivers/bus/qcom-ebi2.c > +++ b/drivers/bus/qcom-ebi2.c > @@ -353,7 +353,7 @@ static int qcom_ebi2_probe(struct platform_device *pdev) > /* Figure out the chipselect */ > ret = of_property_read_u32(child, "reg", &csindex); > if (ret) > - return ret; > + goto err_disable_clk; > > if (csindex > 5) { > dev_err(dev, > @@ -372,8 +372,14 @@ static int qcom_ebi2_probe(struct platform_device *pdev) > have_children = true; > } > > - if (have_children) > - return of_platform_default_populate(np, NULL, dev); > + if (have_children) { > + ret = of_platform_default_populate(np, NULL, dev); > + if (ret) { > + of_platform_depopulate(dev); We can use devm_of_platform_populate() instead (which will match any child node instead of just the simple-bus-y ones, but that's fine) and devm_clk_get_enabled() to handle what you're addressing here, then we need no more unwinding Konrad