From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965285AbcBDDW6 (ORCPT ); Wed, 3 Feb 2016 22:22:58 -0500 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:20035 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbcBDDWy (ORCPT ); Wed, 3 Feb 2016 22:22:54 -0500 From: Ofer Heifetz To: Marcin Wojtas , Thomas Petazzoni CC: Gregory CLEMENT , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , "arm@kernel.org" , "Catalin Marinas" , Will Deacon , Jonathan Corbet , Mark Rutland , "devicetree@vger.kernel.org" , "linux-ide@vger.kernel.org" , Greg Kroah-Hartman , Omri Itach , "linux-kernel@vger.kernel.org" , Nadav Haklai , Hans de Goede , Lior Amsalem , "linux-serial@vger.kernel.org" , Jiri Slaby , Tejun Heo , Wilson Ding , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Thread-Topic: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Thread-Index: AQHRXtFk+Am29S/sbkyFaLvaMKSQTp8bN6gA Date: Thu, 4 Feb 2016 03:22:04 +0000 Message-ID: References: <1454524889-9207-1-git-send-email-gregory.clement@free-electrons.com> <1454524889-9207-4-git-send-email-gregory.clement@free-electrons.com> <20160203230224.5ea52f65@free-electrons.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.94.250.30] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-04_01:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602040056 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u143N4Ma003286 Hi Marcin, I think it is a partial fix since once QA started to use this patch and found that /proc/interrupts prints serial interrupt string multiple times which is clobbering the print. /Ofer -----Original Message----- From: Marcin Wojtas [mailto:mw@semihalf.com] Sent: Thursday, February 04, 2016 12:23 AM To: Thomas Petazzoni; Ofer Heifetz Cc: Gregory CLEMENT; Jason Cooper; Andrew Lunn; Sebastian Hesselbarth; arm@kernel.org; Catalin Marinas; Will Deacon; Jonathan Corbet; Mark Rutland; devicetree@vger.kernel.org; linux-ide@vger.kernel.org; Greg Kroah-Hartman; Omri Itach; linux-kernel@vger.kernel.org; Nadav Haklai; Hans de Goede; Lior Amsalem; linux-serial@vger.kernel.org; Jiri Slaby; Tejun Heo; Wilson Ding; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port I'm sorry, indeed, I was the one to overlook - there was a lot going on in a thread and I missed it. Ofer, as you found out that IRQF_SHARED help booting ubuntu - do you think it's a hack or fix? Best regards, Marcin 2016-02-03 23:02 GMT+01:00 Thomas Petazzoni : > Dear Marcin Wojtas, > > On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote: >> Hi Gregory, >> >> > + port->irq = irq->start; >> > + port->irqflags = 0; >> >> Same request as for v1, which you must have overlooked: >> port->irqflags = IRQF_SHARED; > > Gregory didn't overlook this comment you made on v1, he even replied > to it. Please check Gregory's reply to your review. > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com