mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
	xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org,
	zhujia.zj@bytedance.com
Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] erofs: relinquish volume with mutex held
Date: Thu, 9 Feb 2023 14:14:25 +0800	[thread overview]
Message-ID: <d18fbe06-fec1-2d9a-169e-145fd5ae7c79@linux.alibaba.com> (raw)
In-Reply-To: <fcb92d78-fc5a-8f51-8a1b-75fd878cf8a1@linux.alibaba.com>



On 2/9/23 2:06 PM, Gao Xiang wrote:
> 
> 
> On 2023/2/9 13:18, Jingbo Xu wrote:
>> Relinquish fscache volume with mutex held.  Otherwise if a new domain is
>> registered when the old domain with the same name gets removed from the
>> list but not relinquished yet, fscache may complain the collision.
>>
>> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>> Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>
> 
> Do we need to backport this to old kernels?
> IOWs, whether "Fixes:" tag is needed?

Yeah the small fix is appropriate for being backported.

Fixes: 8b7adf1dff3d ("erofs: introduce fscache-based domain")

I will add the "Fixes" tag in the next version.


-- 
Thanks,
Jingbo

  reply	other threads:[~2023-02-09  6:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  5:18 [PATCH v2 0/4] erofs: cleanup for fscache share domain mode Jingbo Xu
2023-02-09  5:18 ` [PATCH v2 1/4] erofs: remove unused device mapping in meta routine Jingbo Xu
2023-02-09  5:18 ` [PATCH v2 2/4] erofs: maintain cookies of share domain in self-contained list Jingbo Xu
2023-02-09  6:08   ` Gao Xiang
2023-02-09  5:18 ` [PATCH v2 3/4] erofs: relinquish volume with mutex held Jingbo Xu
2023-02-09  6:06   ` Gao Xiang
2023-02-09  6:14     ` Jingbo Xu [this message]
2023-02-09  5:18 ` [PATCH v2 4/4] erofs: unify anonymous inodes for blob Jingbo Xu
2023-02-09  6:02   ` Jia Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d18fbe06-fec1-2d9a-169e-145fd5ae7c79@linux.alibaba.com \
    --to=jefflexu@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    --cc=zhujia.zj@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®