mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Fugate <david.fugate@linux.intel.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Kanchan Joshi <joshi.k@samsung.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
	"Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
	Nitesh Shetty <nj.shetty@samsung.com>,
	SelvaKumar S <selvakuma.s1@samsung.com>,
	Javier Gonzalez <javier.gonz@samsung.com>,
	david.fugate@intel.com
Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append
Date: Wed, 19 Aug 2020 15:54:20 -0600	[thread overview]
Message-ID: <d19605da52eb7aa3eb4132ad1781b5fbf636a8a0.camel@linux.intel.com> (raw)
In-Reply-To: <9fa64efe-8477-5d33-20ed-9619a9fe8d70@kernel.dk>

On Wed, 2020-08-19 at 13:25 -0600, Jens Axboe wrote:
> It's not required, the driver will function quite fine without it. If
> you
> want to use ZNS it's required. 

The NVMe spec does not require Zone Append for ZNS; a *vendor-neutral*
Linux driver should not either. 

> The Linux driver thankfully doesn't need
> any vendor to sign off on what it can or cannot do, or what features
> are acceptable.

The problem is the driver needs one *particular* vendor to sign off.
Existing driver behavior aligns with WDC drives instead of the spec,
giving WDC an unfair advantage. Couple this with NVMe maintainer(s?)
working for WDC, and there's a conflict of interest.

> It's *always* ok to reject contributions, if those contributions
> cause
> maintainability issues, unacceptable slowdowns, or whatever other
> issue
> that the maintainers of said driver don't want to deal with. Any
> contribution should be judged on merit, not based on political
> decisions
> or opinions.

Agreed, but this standard needs to be applied equally to everyone.
E.g., harmless contributions such as 
https://lore.kernel.org/linux-nvme/20200611054156.GB3518@lst.de/ get
rejected yet clear spec violations from maintainers are accepted? This
type of behavior encourages forking, vendor-specific drivers, etc.
which is somewhere I hope none of us want to go.



  reply	other threads:[~2020-08-19 21:54 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200818053247epcas5p262c5fd7e207dfa5145011c4329cf239d@epcas5p2.samsung.com>
2020-08-18  5:29 ` [PATCH 0/2] enable append-emulation for ZNS Kanchan Joshi
     [not found]   ` <CGME20200818053252epcas5p4ee61d64bba5f6a131105e40330984f5e@epcas5p4.samsung.com>
2020-08-18  5:29     ` [PATCH 1/2] nvme: set io-scheduler requirement " Kanchan Joshi
2020-08-18  7:11       ` Christoph Hellwig
2020-08-19  9:26         ` Kanchan Joshi
2020-08-19  9:38           ` Damien Le Moal
2020-08-19 10:31             ` Kanchan Joshi
2020-08-19 11:17               ` Damien Le Moal
2020-09-07  7:00                 ` Kanchan Joshi
2020-09-07  8:22                   ` Damien Le Moal
2020-09-07 11:23                     ` Kanchan Joshi
2020-09-07 11:37                       ` Damien Le Moal
2020-09-07 11:54                         ` Kanchan Joshi
2020-09-07 12:53                           ` Damien Le Moal
     [not found]   ` <CGME20200818053256epcas5p46d0b66b3702192eb6617c8bba334c15f@epcas5p4.samsung.com>
2020-08-18  5:29     ` [PATCH 2/2] nvme: add emulation for zone-append Kanchan Joshi
2020-08-18  7:12       ` Christoph Hellwig
2020-08-18  9:50         ` Javier Gonzalez
2020-08-18 10:51           ` Matias Bjørling
2020-08-18 18:11             ` Javier Gonzalez
2020-08-18 15:50           ` Christoph Hellwig
2020-08-18 18:04             ` Javier Gonzalez
2020-08-19  7:40               ` Christoph Hellwig
2020-08-19  8:33                 ` Javier Gonzalez
2020-08-19  9:14                   ` Damien Le Moal
2020-08-19 10:43                     ` Christoph Hellwig
2020-08-20  6:45                       ` Javier Gonzalez
2020-08-19 10:49                   ` Christoph Hellwig
2020-08-18 16:58           ` Keith Busch
2020-08-18 17:29             ` Javier Gonzalez
2020-08-18 17:39               ` Keith Busch
2020-08-18 18:13                 ` Javier Gonzalez
2020-08-19 19:11         ` David Fugate
2020-08-19 19:25           ` Jens Axboe
2020-08-19 21:54             ` David Fugate [this message]
2020-08-19 22:10               ` Keith Busch
2020-08-19 23:43                 ` David Fugate
2020-08-20  3:45                   ` Keith Busch
2020-08-20 23:26                     ` David Fugate
2020-08-20  5:51                   ` Christoph Hellwig
2020-08-20  6:37             ` Javier Gonzalez
2020-08-20  6:52               ` Christoph Hellwig
2020-08-20  8:03                 ` Javier Gonzalez
2020-08-19 21:42           ` Keith Busch
2020-08-20  7:37             ` Kanchan Joshi
2020-08-20  8:14               ` Javier Gonzalez
2020-08-20  5:29           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d19605da52eb7aa3eb4132ad1781b5fbf636a8a0.camel@linux.intel.com \
    --to=david.fugate@linux.intel.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=david.fugate@intel.com \
    --cc=hch@lst.de \
    --cc=javier.gonz@samsung.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nj.shetty@samsung.com \
    --cc=sagi@grimberg.me \
    --cc=selvakuma.s1@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome