From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77D834C818; Tue, 10 Feb 2026 10:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770720517; cv=none; b=gt+7zUpey65lFEanTLATbz9doKhN+JCKV5v5ZET8ENoUcrDj05Z4yXzkr7W4fFjfgfarz6pBpMbwRsWYvP3W0fOcZQALWKQwcPkoJImh6zDIYrjZAPhOUQY3BoExY9GoxERu14PWKMFimM6bBFtsPa8a4zMsEzC11IlYBrukQgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770720517; c=relaxed/simple; bh=2MGagsI5N9rYn5ZNhSryX3LibXOg4qkEQq2vRbnKowI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gAawNFUwoCitaATkp0Z6cYneghP2abbM0HSHFc/DPnpXAlH5n4ToZnPErKpg38LJ2YI96bDK/zN2KjMKZcpf6GOg4wudQz02Kaih5FLrYTDUVDbaGAzCt7RV/tkQHhwIMcGQ6xL5GKFDmqrUZ/Wu+hUUwT2y+NSb8r6XlTy9oeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ggPFJ/LV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ggPFJ/LV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA3CAC116C6; Tue, 10 Feb 2026 10:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770720517; bh=2MGagsI5N9rYn5ZNhSryX3LibXOg4qkEQq2vRbnKowI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ggPFJ/LVxz06G2/mzwM8U5VEB3zSHKGy0GWnZZIJRAPVe/66CFxRsfpwbhLngktVr 9OSjHMdLGBcja2Zt/8Qo/9Nj2SJvaovZSwHNAYEchr8aujXjL7P33by7EBFb6znxWF 6pTslXhk+xaEhNkQJqy9Wu7UAJBtk0DEe7V1aXH4jpazaXFINAgMJZ7lIZCskLUOhC DI/Ubhi/0R2RzNEJnvbgQ9MVuvJ9BgBGnzWuiKJFWYDuOaoDgNtdtW/g2h6axCmcGk JECktCb0UDpUmztd2RLI9PtoFKI17bZU8/Ka0Fl9QxOPIwlJYAxnb0RDOoknezL+tR iu+o1BeBSMt3A== Message-ID: Date: Tue, 10 Feb 2026 11:48:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/9] dt-bindings: mfd: document ASUS Transformer EC To: Svyatoslav Ryhel Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Ion Agorria , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org References: <20260209104407.116426-1-clamor95@gmail.com> <20260209104407.116426-4-clamor95@gmail.com> <20260210-sexy-grumpy-sambar-44edd2@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/02/2026 10:37, Svyatoslav Ryhel wrote: > вт, 10 лют. 2026 р. о 11:22 Krzysztof Kozlowski пише: >> >> On Mon, Feb 09, 2026 at 12:44:01PM +0200, Svyatoslav Ryhel wrote: >>> Document embedded controller used in ASUS Transformer device series. >>> >>> Signed-off-by: Svyatoslav Ryhel >>> --- >>> .../devicetree/bindings/mfd/asus,ec.yaml | 152 ++++++++++++++++++ >>> 1 file changed, 152 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mfd/asus,ec.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/asus,ec.yaml b/Documentation/devicetree/bindings/mfd/asus,ec.yaml >>> new file mode 100644 >>> index 000000000000..1d1a62761b71 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/asus,ec.yaml >> >> EC do not go to MFD, but to dedicated directory (there is such). >> > > Noted > >>> @@ -0,0 +1,152 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/asus,ec.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: ASUS Transformer's Embedded Controller >>> + >>> +description: >>> + Several Nuvoton based Embedded Controller attached to an I2C bus, >>> + running a custom ASUS firmware, specific to the Asus Transformer >>> + device series. >>> + >>> +maintainers: >>> + - Svyatoslav Ryhel >>> + >>> +properties: >>> + compatible: >>> + oneOf: >> >> Drop oneOf >> > > Noted > >>> + - enum: >>> + - asus,ec-pad # Pad part of Asus Transformer >>> + - asus,ec-dock # Dock part of Asus Transformer >> >> >> Compatibles are way too generic. "ec" basically means you document all >> Asus EC, which is for sure not true. You need specific compatible for >> this specific model. >> > > Asus were not so generous to provide more specific data, they call > there controllers asusdec and asusped in their sources. Look how other ECs are called. Your device is not "", but e.g. "Transformer". > >> Missing blank line. >> > > noted > >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + request-gpio: >> >> gpio is deprecated. gpios, look at any other binding. >> > > noted > >>> + maxItems: 1 >>> + >>> + asus,dockram: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: I2C device used to access power related functions. >>> + >>> + asus,clear-factory-mode: >>> + type: boolean >>> + description: clear Factory Mode bit in EC control register >> >> Why would this be a static/fixed property over lifecycle of all devices? >> > > Specify pls. Provide rationale why we need to clear it every time, not once. Or any other rationale why we would accept that property. > >>> + >>> + battery: >>> + type: object >>> + $ref: /schemas/power/supply/power-supply.yaml >>> + unevaluatedProperties: false >>> + >>> + properties: >>> + compatible: >>> + const: asus,ec-battery >>> + >>> + required: >>> + - compatible >>> + >>> + charger: >>> + type: object >>> + $ref: /schemas/power/supply/power-supply.yaml >>> + additionalProperties: false >>> + >>> + properties: >>> + compatible: >>> + const: asus,ec-charger >>> + >>> + monitored-battery: true >>> + >>> + required: >>> + - compatible >>> + >>> + keyboard-ext: >>> + type: object >>> + description: top row of multimedia keys >>> + additionalProperties: false >>> + >>> + properties: >>> + compatible: >>> + const: asus,ec-keys >>> + >>> + required: >>> + - compatible >>> + >>> + led: >>> + type: object >>> + additionalProperties: false >>> + >>> + properties: >>> + compatible: >>> + const: asus,ec-led >>> + >>> + required: >>> + - compatible >>> + >>> + serio: >> >> All of these children are pointless - no resources. Drop all of them, >> it's btw explicitly documented rule in writing bindings. >> > > They are all needed to be able to disable them individually from the > device tree if needed. They should not be disabled from DT, so they are not valid here. The given EC for given device is fixed/static. Does not change. Best regards, Krzysztof