mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: rostedt@goodmis.org, mhiramat@kernel.org,
	linux-trace-kernel@vger.kernel.org,
	mathieu.desnoyers@efficios.com, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tracing: Fix simple_ring_buffer undef check on sparc64
Date: Thu, 24 Sep 2026 19:31:43 -0700	[thread overview]
Message-ID: <d1994ad3-473c-4157-902b-89b0ae3fcc6d@roeck-us.net> (raw)
In-Reply-To: <20260923074213.3077182-4-vdonnefort@google.com>

On Wed, Sep 23, 2026 at 08:42:13AM +0100, Vincent Donnefort wrote:
> simple_ring_buffer relies on headers that end up including
> <asm/thread_info.h>. On sparc64, this emits the undefined symbol
> current_thread_info_reg. Allow this symbol.
> 
> Fixes: 1211907ac0b5 ("tracing: Generate undef symbols allowlist for simple_ring_buffer")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/all/5574c9e6-9ed2-4ee6-a2b2-fb6ee81e83a1@roeck-us.net/
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  kernel/trace/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index 0e1846f7dda3..3860bc53a4be 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -146,6 +146,7 @@ KASAN_SANITIZE_undefsyms_base.o := y
>  
>  UNDEFINED_ALLOWLIST = __asan __gcov __kasan __kcsan __hwasan __sancov __sanitizer __tsan __ubsan __msan \
>  		      __aeabi_unwind_cpp __s390_indirect_jump __x86_indirect_thunk simple_ring_buffer \
> +		      current_thread_info_reg \
>  		      $(shell $(NM) -u $(obj)/undefsyms_base.o 2>/dev/null | awk '$$2 {print $$2}')
>  
>  quiet_cmd_check_undefined = NM      $<
> -- 
> 2.55.0.1082.g2b9226bbc0-goog
> 

      reply	other threads:[~2026-09-25  2:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  7:42 [PATCH 0/3] tracing: Fix simple_ring_buffer symbol checking on parisc and sparc64 Vincent Donnefort
2026-09-23  7:42 ` [PATCH 1/3] tracing: Fix empty symbol names in simple_ring_buffer undef check Vincent Donnefort
2026-09-25  2:31   ` Guenter Roeck
2026-09-23  7:42 ` [PATCH 2/3] tracing: Fix simple_ring_buffer undef check on parisc Vincent Donnefort
2026-09-25  2:31   ` Guenter Roeck
2026-09-23  7:42 ` [PATCH 3/3] tracing: Fix simple_ring_buffer undef check on sparc64 Vincent Donnefort
2026-09-25  2:31   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1994ad3-473c-4157-902b-89b0ae3fcc6d@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®