From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC90C7C08B for ; Mon, 4 Mar 2024 22:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709592786; cv=none; b=ZeZZWGCtA6wvIb/meNVaQMK3AVoN9Qx1PiIGMvl3yQa2PI/wjhsSC0Zanl/SjjKeXTMNnMeONEkNTuks0HdeGUvXN7IRQKgeIx9JhEzK4OdkSYO8jE+f+wMSCBzECQbTZ+vuwU7NGnkbu6ZXX/Zj4lcivI2g5yVNwbq09E9zyt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709592786; c=relaxed/simple; bh=uOmNJyftoQiWMBwtZjjEk5oazk42oiXZB0+69cEngE4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i7YtTpMhJivcp9xw4N7g6dMvFzGVfrSS8qua501kO5iW9YkrpVLD0EJunVCnuG3zUV5EfqHRTEyZu0xW0UbrhzFyqWHQNYUL+63UmDmp8OCWGtPQGIcz+Ssj5nps/f/mOKKcWcQhW0FUsF89Q75EEkcaT7onGwftvL75Au9bpCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fSDidsuR; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fSDidsuR" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-412ecc1064cso260935e9.2 for ; Mon, 04 Mar 2024 14:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709592783; x=1710197583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=btWynTf3xFFc3JW3PLqmWTjuLdoAa7Aj4yAc6WIdAsM=; b=fSDidsuRb/fJIChlTqzSZiqzRASaUAjwx66r8Wtd3lt6Xr4vrhfMtYjzE1XLiQRm5I Juk8U65YTFVeJTmrJ3CIbsUVwJXp75fxp5BSG9cRGHWT4QXoVpWlgUJcCPwk0fdTodnd PyzniKmtxh5ezNjpOU5TmOmM/fTukigihkDz+Oz7WiWXwCzon02CgjLgdm9E+cQ+o+hB v0Gto+5ag/YH7U2vGP8C3T1gkGeBCPwe1XNpDo8unGPXLZJmryfYd8MhOVHPl+S906cC TDJCWZIW5fGWxpCg+3c709bvw+ShpGzrBhL22ALht/DCoVcssYPqz+fjdMVUf3wiiDBk UaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709592783; x=1710197583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btWynTf3xFFc3JW3PLqmWTjuLdoAa7Aj4yAc6WIdAsM=; b=hgh4qvyqbTjY00OsEe+7viuSfkWkGJvBcFCQVmZjNbOhqfqJ8gz9AiirA2ojck0CR1 sT+1ft8ZFi6FkYFfHQ0YegYVdQrKpvqORjS2S+z1kfLKz6spfzoG0PW7JYMLOKaSfhVa IZHybRDHtS053xHZzGnvjMNlmkDOv5gTz4C8C7LFdcxP1iGvaxV4u5XuuSgi26sB5Peg UxnDo1KR8gMPk+CETFTHFSRt80aIgrX2uK5N6ueXIhBZqCow1XAtZYMTlUIhBGE/CNTo fNND9RQHrPFQf8HVQgDG+XtLhYAyFazLtYksNn2uE7hNPEX48SfVAu0ShyNibasiuAvT FHKA== X-Forwarded-Encrypted: i=1; AJvYcCXX1VpfNY+JBtKY63nVpXkCPXG840UzVrMxIxcBRz8Kdb7WrcWiOByi6aymI4FTfQpg/d7Bk9qyL5edPZO3BWGCKAdFdmQ7HhW5NZz8 X-Gm-Message-State: AOJu0YyHY0bbQTVqavbNgOoAA4xQtHRwPhohLMIx1AvlmqcBhqBdp9sg gRmL3ThAAUoMxAUEAfk1MgzkKn5YI8TBhKLEhNwQF2eiC+ttC/7Vz9qc2j0QvwE= X-Google-Smtp-Source: AGHT+IFuHz8KuYiUldcamRZfnck6yCpPU0D3qbH8MnGNSebMlrRChLNBuPmNutjEvsdtyjLBHd+6Xw== X-Received: by 2002:a05:600c:4e8e:b0:412:de1f:dd23 with SMTP id f14-20020a05600c4e8e00b00412de1fdd23mr3813219wmq.7.1709592783279; Mon, 04 Mar 2024 14:53:03 -0800 (PST) Received: from [10.66.66.2] (9.ip-51-91-159.eu. [51.91.159.9]) by smtp.gmail.com with ESMTPSA id bi7-20020a05600c3d8700b00412e5f876adsm3186236wmb.3.2024.03.04.14.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 14:53:02 -0800 (PST) Message-ID: Date: Mon, 4 Mar 2024 23:52:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/20] media: venus: pm_helpers: Remove pm_ops->core_put To: Dikshita Agarwal , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Philipp Zabel Cc: Marijn Suijten , Stanimir Varbanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20230911-topic-mars-v2-0-3dac84b88c4b@linaro.org> <20230911-topic-mars-v2-14-3dac84b88c4b@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/4/24 07:57, Dikshita Agarwal wrote: > > > On 2/10/2024 2:39 AM, Konrad Dybcio wrote: >> Without an OPP table and with vcodec_pmdomains_num (so, v1, v3 and >> sdm845_legacy targets), core_put_v4 is a NOP, jut like core_put_v1. >> Unify them! >> >> Signed-off-by: Konrad Dybcio >> --- [...] >> -static void vcodec_domains_put(struct venus_core *core) >> +void vcodec_domains_put(struct venus_core *core) >> { >> dev_pm_domain_detach_list(core->pmdomains); >> > what is the base of this change? > I don't see dev_pm_domain_detach_list in mainline code. > Am I missing anything here? The base is specified in the cover letter. The code in question is indeed here since January, perhaps you're looking at something older than -next. Konrad