From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Dave Penkler <dpenkler@gmail.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: drivers/staging/gpib/common/gpib_os.c:871 ibioctl() warn: inconsistent returns '&board->big_gpib_mutex'.
Date: Mon, 9 Dec 2024 12:08:31 +0300 [thread overview]
Message-ID: <d19c29ac-a084-4feb-a272-5ae6361732db@stanley.mountain> (raw)
In-Reply-To: <869e62e1-cdcb-47b3-8092-2d5c203ecf1a@stanley.mountain>
On Mon, Dec 09, 2024 at 09:50:15AM +0300, Dan Carpenter wrote:
> 9dde4559e93955 Dave Penkler 2024-09-18 757 switch (cmd) {
> 9dde4559e93955 Dave Penkler 2024-09-18 758 case IBEVENT:
> 9dde4559e93955 Dave Penkler 2024-09-18 759 retval = event_ioctl(board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18 760 goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18 761 case IBCLOSEDEV:
> 9dde4559e93955 Dave Penkler 2024-09-18 762 retval = close_dev_ioctl(filep, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18 763 goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18 764 case IBOPENDEV:
> 9dde4559e93955 Dave Penkler 2024-09-18 765 retval = open_dev_ioctl(filep, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18 766 goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18 767 case IBSPOLL_BYTES:
> 9dde4559e93955 Dave Penkler 2024-09-18 768 retval = status_bytes_ioctl(board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18 769 goto done;
> 9dde4559e93955 Dave Penkler 2024-09-18 770 case IBWAIT:
> 9dde4559e93955 Dave Penkler 2024-09-18 771 retval = wait_ioctl(file_priv, board, arg);
> 9dde4559e93955 Dave Penkler 2024-09-18 772 if (retval == -ERESTARTSYS)
> 9dde4559e93955 Dave Penkler 2024-09-18 773 return retval;
>
> mutex_unlock(&board->big_gpib_mutex) before returning.
>
Sorry, this is a false positive. The kbuild-bot can't use cross function
analysis because it doesn't scale. But if you had cross function analysis
enabled then it wouldn't have printed this false positive.
regards,
dan carpenter
prev parent reply other threads:[~2024-12-09 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 6:50 Dan Carpenter
2024-12-09 9:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19c29ac-a084-4feb-a272-5ae6361732db@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®