mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Mike Christie <michael.christie@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: core: Make scsi_lib KUnit tests modular for real
Date: Tue, 19 Mar 2024 09:03:45 -0700	[thread overview]
Message-ID: <d1a1b0b8-41f1-4ead-b393-d8d2f099b0c4@acm.org> (raw)
In-Reply-To: <48ca5e827ca420bbdbabb1643e2179dc95c9e0b7.1710849638.git.geert@linux-m68k.org>

On 3/19/24 05:02, Geert Uytterhoeven wrote:
> While SCSI_LIB_KUNIT_TEST is a tristate config symbol, configuring a
> modular build of this test does not do anything: as the test code is
> just included by the mid layer code, it only works in the built-in case.
> 
> Fix this by converting the test to a stand-alone module.  This requires
> exporting scsi_check_passthrough() and adding a MODULE_LICENSE() tag.

I don't like it that scsi_check_passthrough() is exported so that counts
as a disadvantage of this patch. Why to convert scsi_lib_test into a
kernel module? What are the advantages compared to the current approach?
That information is missing from the patch description.

Thanks,

Bart.

  reply	other threads:[~2024-03-19 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 12:02 Geert Uytterhoeven
2024-03-19 16:03 ` Bart Van Assche [this message]
2024-03-19 16:10   ` Geert Uytterhoeven
2024-03-19 17:01     ` Bart Van Assche
2024-03-20  8:08       ` Geert Uytterhoeven
2024-03-20 15:07         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1a1b0b8-41f1-4ead-b393-d8d2f099b0c4@acm.org \
    --to=bvanassche@acm.org \
    --cc=geert@linux-m68k.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®