From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B541E9B1A for ; Mon, 23 Feb 2026 10:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841380; cv=none; b=hlToGSe7wOrocdL1RPNA33C4Ile3Evn/GKMLtLWCnzpZfxh1zV2wdKptfVSY/z2z5B7m2Kb0PhpC2GwqimB/tnvkCFhjYbkY081RPFkW7JGAumcUG7pxKytrJMSjbrgqvF4HBtHcEUEciDG/asuvaIsHethVRo1+V/HQM7yzaFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841380; c=relaxed/simple; bh=Ky3jcIBbGAp358Kb7hZKDppR/DA4Xry1FogPtt3x2sE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FMYnk9OESCm1BzmGj9lXjZCueR9z9M74hJ6lPecwS50gfZfUjmyD1fo49RyRNE2+2bTrJARnYWKUQ/kh0hNIYptVFlLAZNj1jlM54k65nqWGWC4BTHshHOH+QYizKk2WTWf3alN+12gqGt9tf9fUxY7a0xoEBEtcVcxJBz/YO00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YaZ5atst; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YaZ5atst" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4834826e555so39712465e9.2 for ; Mon, 23 Feb 2026 02:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771841378; x=1772446178; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Y3U0wiZ1PaLP9HKufniCA3p+26o0xtDqndh6mBEwyx0=; b=YaZ5atstiuyyX/KZ4RGNr8CAywUBCCig5Wo62ckOMjU3Ar02DldYn69p7x3kgXyS0S gWClepkcbbcupsiVSlusldMOEVWNxCTcN6V7W7LvwAmasazxHXvic6YyJJf6ATOSOzur bh0SWGvIh7B+pKF+1P3iKhXN0GiCgsOfbpgkLKWi4C8P1XO1X0G0IXlIB71KZk8RiDq0 IhuGbODNEdkycFjdKIHlKTmNnebWIBRc7Syt9Mw2ntlYUmsi3F4Q7a9ODtnf4M2YiULq IHde9fhM018Mc3nNuiz+UgvI7DMmj22TrusJmUPSppNC+uqz62pqIWuW6Gr120WqPufw tLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841378; x=1772446178; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y3U0wiZ1PaLP9HKufniCA3p+26o0xtDqndh6mBEwyx0=; b=oWM0A3+u/ZUAM5sc6GmryR8qrI6HUlefi7M02JpVGEAUhJjN3jxfJDXo/uQ0CeJAGR gyJManFIGuReWHBrnG/+KdarVLEBcYZM3EyNTQTVQeZGOr6rsvki9CxMg0JzZb163lMt duMnJVBbXDmBOtYs4TdqodKOYZPlTcXEmvEgX0uXoEPtBP8fzG+1GCr/SOWoX4ix64KS aYOthG4tyliDj5FTjvFGCevj+DVHPYQ8aOmRwvYjQVStPo4h9ZECh4bSxAOY4AM7w+2h msA0sIpprEibHovdVBPvK+42PcLyg2CHiiOTuLhaYLj2cLaGVSqNamDnt/hJNGIrZRFD gyFg== X-Forwarded-Encrypted: i=1; AJvYcCXDTio3z7B1wT1mf++z/dGhemFfTj4Lx8+hRr11QSjhw95kreVb99D7lttbQMp1SkRHzfRz803ot1NBgsw=@vger.kernel.org X-Gm-Message-State: AOJu0YyE4er+nDOV7jE7kz8a2+ed7sgPTbsgQI1gMZabK2uHySzZ3Ih2 +1BBPq+GPdLtky/kegOCbRRSTMN54/Dw2HOeSmW4F8S6CA0wYJ+Ve4ot X-Gm-Gg: AZuq6aLOxiZe5aKngxGEm80qcyrmIa5MfzZa5XGOM7PKvp3mAHsJerTzwGqTRuxThYL K27AN9rDiw/eBhIsNVE4A9NZsWFMSLApof6kygxQhDyOGb0cyjtcgn4GpwCZwWp2PTEkPylWEi2 hWxE5U/VvpvASLnQqGHvJyEYlzwp3hCuR1w6M1nFYO/6C5+hNsSLrZnooe8qdgHmsJD6iUg84sa GKpHRoLxNhmYsgWM0ki85Le/86xlyBPNuyICaFxuq5y3/OLPFXVxsmeqEpoPJqLbHteZ71Gtl2L /XZnEyxOholi6vYINzIFBcjM5BerHkNbNCBHUuyH0pATGHGHF8KzaJdPiGREOQEXou8Jwd0ANzy ta4oAeEz7Tj8X+yXyuJfETrRlxxiAl7H6ImW8RL2KnSk3cD7l2Kc73SiCTAvQlUD6w4acb6feAP Y8iYocq7kNzU8RcZCoXBFDad9ZW8s/5AJ7wyBGQZCGig== X-Received: by 2002:a05:600c:34d3:b0:47a:975b:e3e6 with SMTP id 5b1f17b1804b1-483a962e175mr136244295e9.18.1771841377468; Mon, 23 Feb 2026 02:09:37 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31bc068sm245815725e9.4.2026.02.23.02.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:09:37 -0800 (PST) Message-ID: Subject: Re: [PATCH 2/3] iio: dac: ad5706r: Add support for AD5706R DAC From: Nuno =?ISO-8859-1?Q?S=E1?= To: Andy Shevchenko Cc: Alexis Czezar Torreno , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Date: Mon, 23 Feb 2026 10:10:20 +0000 In-Reply-To: References: <20260220-dev_ad5706r-v1-0-7253bbd74889@analog.com> <20260220-dev_ad5706r-v1-2-7253bbd74889@analog.com> <4fd329ed6416fd2f8e2a72adfa5a77f73107948b.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-02-20 at 18:56 +0200, Andy Shevchenko wrote: > On Fri, Feb 20, 2026 at 03:02:37PM +0000, Nuno S=C3=A1 wrote: > > On Fri, 2026-02-20 at 13:00 +0200, Andy Shevchenko wrote: > > > On Fri, Feb 20, 2026 at 10:48:59AM +0000, Nuno S=C3=A1 wrote: > > > > On Fri, 2026-02-20 at 16:02 +0800, Alexis Czezar Torreno wrote: >=20 > ... >=20 > > > > > +static void ad5706r_debugs_init(struct iio_dev *indio_dev) > > > > > +{ > > > > > + struct dentry *d =3D iio_get_debugfs_dentry(indio_dev); > > > >=20 > > > > It should have: > > > >=20 > > > > if (!IS_ENABLED(CONFIG_DEBUGFS)) > > > > return > > >=20 > > > But why? The debugfs is a stub when disabled, nobody should do that > > > in the cases when the main purpose is not the debugfs code. > >=20 > > Because the compiler can then optimize away all of the above code... >=20 > How is it different to the code elimination part that is inside in each o= f > the below calls? Clearly none :). For some reason I thought it would matter. Maybe I was mis= taken by some old code that had #ifdef guards on the debug code. Any ways, I might send some patches cleaning some places where I added the = above so people do not copy it around. - Nuno S=C3=A1 >=20