From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, Roger Quadros <rogerq@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()
Date: Thu, 27 Jun 2019 10:24:21 -0500 [thread overview]
Message-ID: <d1a5c892-abc1-8978-67ee-92c4ecb3622a@ti.com> (raw)
In-Reply-To: <20190627121158.GJ5447@atomide.com>
On 6/27/19 7:11 AM, Tony Lindgren wrote:
> Hi,
>
> * Suman Anna <s-anna@ti.com> [190625 23:33]:
>> The clocks are not yet parsed and prepared until after a successful
>> sysc_get_clocks(), so there is no need to unprepare the clocks upon
>> any failure of any of the prior functions in sysc_probe(). The current
>> code path would have been a no-op because of the clock validity checks
>> within sysc_unprepare(), but let's just simplify the cleanup path by
>> returning the error directly.
>>
>> While at this, also fix the cleanup path for a sysc_init_resets()
>> failure which is executed after the clocks are prepared.
>
> Sounds like this should get queued separately as a fix for v5.3-rc
> cycle, probably got broken with the recent ti-sysc init order changes.
Yeah, this patch does not depend on the previous 4 patches, so can be
picked up independently for v5.3-rc as well.
regards
Suman
next prev parent reply other threads:[~2019-06-27 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 23:33 [PATCH 0/5] Minor ti-sysc cleanups Suman Anna
2019-06-25 23:33 ` [PATCH 1/5] MAINTAINERS: Add ti-sysc files under the OMAP2+ entry Suman Anna
2019-06-25 23:33 ` [PATCH 2/5] dt-bindings: ti-sysc: Add SPDX license identifier Suman Anna
2019-06-25 23:33 ` [PATCH 3/5] bus: ti-sysc: Switch to " Suman Anna
2019-06-25 23:33 ` [PATCH 4/5] bus: ti-sysc: Add missing kerneldoc comments Suman Anna
2019-06-25 23:33 ` [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe() Suman Anna
2019-06-27 12:11 ` Tony Lindgren
2019-06-27 15:24 ` Suman Anna [this message]
2019-08-13 10:59 ` Tony Lindgren
2019-07-01 7:18 ` [PATCH 0/5] Minor ti-sysc cleanups Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1a5c892-abc1-8978-67ee-92c4ecb3622a@ti.com \
--to=s-anna@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®