From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5403326CE39 for ; Wed, 18 Feb 2026 11:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413176; cv=none; b=j+qxRzcO4ogBhV7iOSQo8LXOCyPx5JFMq+K4BAYuhp2QAzP1Hphd543EnR7QJv4JZzUnO0djPvrZNtq+Iyi8ZPpvGahs9biqOxarJumg9UWAJht/mayHfFk8aJXvcsl86DQR4SgdUZSxmjOL8YUj9BcB4AtsCKRFw7NS7KHFHHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771413176; c=relaxed/simple; bh=4YT5brYB0UAoqFBI858XsuI2Vt7FEqOK1Z3AeX/HKPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lhI/193nNF4yMCljnNJbaIdT+aZ+3ZBFsBVdOP/A2Yv9q87OLDb9NlEvOZkgP7ipt2pCALkPYJrr1DCscBqkCHL2sO53EjQ+PHOPPO9EN7UyRP0Drf0dDiQQY0VdacZokZOAORmCJWf6vyxQGso2SaXEC0iDSf5XPa+4jKN1c64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QsTn2jWw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IrUtnuag; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QsTn2jWw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IrUtnuag" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61I5OdFg4025101 for ; Wed, 18 Feb 2026 11:12:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /+3N+xY8cLZlUDcYTClcCN8YabWFK8vIUfB/T72lyAg=; b=QsTn2jWwMsn8ZyTF ljiDjuAMO9FNP0d50XQlr9r1OQSTyYBQeUs3e9CpAOiu6bFwHr6IfytbzZvpvHzy M1L0YRbZCSKZt7gk1HI0KPVbJaCpBjaeopJyVc8EZ8SoyUqeUSwTH40qahFbCkcj pnwX80Aq21qBxZNaanHIdrNC2AMJMdgqgsNfgZpnnVx1+MLzAacm35KlEfhY+Hqg BCZLChRJ9nYSC0sOvC24kcpO9vqwPNYob5IjWZsDmqU9qYwf8Mau1NLU4drARnCk 5FsIaEofKANu1c2B1V7X9JFH66mq/Y7M/YpKQM4N/JnNVrTEG2LUMN0F/4IIM76y bHIVlw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd78c0ujp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 11:12:54 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8960257db65so39683906d6.3 for ; Wed, 18 Feb 2026 03:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771413173; x=1772017973; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/+3N+xY8cLZlUDcYTClcCN8YabWFK8vIUfB/T72lyAg=; b=IrUtnuagQFhTeFjlpHC1nW0gAMc9oV2s6HlWnoJSMWrs7Blo1pKid18egZZPSrM28z pJC7w7W/6dX9luFnaobgRlv/4/5xTQ5jsIJM8H33QNIwvRw9NNvpBFqW73YmPw9S5KrH X76u+/o9/kfZvrWfrGlbQsuOdINGI4ks1umfehNUNoLdBhbwrKqecsva9d36ArlxOtNP 1jp8s6H95jGynPk6R+0HNjgXB5d8V1dJDpLrYeKkpBZbgtDhMNdLF7XGYWXfe3/paNhB bT2Jy8ckKr7uCZpxaruVCmwoCmeENvLYpwYCyz8iHXz29qMLM5Y1atV+C2Sq+ILLA0NY /t/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771413173; x=1772017973; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/+3N+xY8cLZlUDcYTClcCN8YabWFK8vIUfB/T72lyAg=; b=rpW+feT6IFI2nwRcRdFZe0JTqZ5IbYxu+wonprQiPuXCQGK/uLjiAonxUYE2w/V7tY W+40d1w87ikKe9Ip9Dp4wfQleI5W4e+HzKtM534W2dbUSYLb7x1p4XpjP08OizdLQ9h9 FprHXz7scncW4M6vnputzU4AFCMgeQO1RQFjAe4zkchDT99fanM1dHNG+Ao4L/+Yn/Gm nK/K+a4yUyYBwIRuCbwsZsKVK/NdMNDdJ+plIYPkKhTQcM3oexoYoTy8JEBeXTIwKuOE vebPLuUSZFFvs6ahdtN1URcPhorDwmtFp0nfbgFDT3hJonsMJzUbMAWbYsI1VJH/UasX LkiA== X-Forwarded-Encrypted: i=1; AJvYcCX6lsXFLZU0BsOM2mQBcRbRtfI7/DDAdsoUNnei3WHUD6YWkGsteUnPrcha1qdNv3S1ZA3JHiB/ZxbNNC4=@vger.kernel.org X-Gm-Message-State: AOJu0YyVvFqx7aHOR+MhbE9iAP0s4VKC2mJahBwCAfpCC0Ok3eATIcRu TVzCV/wBJ9/HBHoo1CI6rKJ/6Jf+aGV41Sct5R+abOs/JkZsR4Ipp0cbgEz132o0Uu68D9UdFL8 T0VUlWwF4/BZJWlYOTmJmGWVbmzPHksflEdp6TKQqJbDMWALXMDY91y8n77WRg3poGQM= X-Gm-Gg: AZuq6aKAsgLDYXXsTINaF2bYoNqFztGykTEmnFBv/944h64iWRHqkBoBhNf+b9uSvrh tf0ZcIMHsOpQCrv/MoaHFj9+VCCihdNVDPlQd0r220KD+DthxNHH8AnTdlndXW60agZQlCoVtNK IVZ/I94OULCy25SUJLrRL+Dpm8WOVmEJXtUv0LAdgEQhK3PJH8ICe4lwNL5iTJ3jsfsk96FhNXW 6ngjmYO/gMMDZYHPNX1WZ6sdcVlZh9lQivu/LPgGg+zgzfZTRcqtn3Y12H1zw4GzFHSsIO2FPdE 5CQZ6N6bbxkrLG7SD+YETItvwlFIckLodeNhEw1CDf9ziGLSM8KhUOo6Res3oNNQEjUAF4Q6o3z 0M194+PaLfV1r00uE39f3VNXVUaNQMuwNgeLeW7Xs1zvxBKcm+ShyDJnY7EDuaxvmYAXxIowdps Rwqmc= X-Received: by 2002:a05:6214:4c42:b0:894:9f0a:7a69 with SMTP id 6a1803df08f44-89734706f3fmr182245116d6.2.1771413173567; Wed, 18 Feb 2026 03:12:53 -0800 (PST) X-Received: by 2002:a05:6214:4c42:b0:894:9f0a:7a69 with SMTP id 6a1803df08f44-89734706f3fmr182244906d6.2.1771413173135; Wed, 18 Feb 2026 03:12:53 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bace3fc4esm3120910a12.0.2026.02.18.03.12.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 03:12:52 -0800 (PST) Message-ID: Date: Wed, 18 Feb 2026 12:12:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] crypto: qce - Add runtime PM and interconnect bandwidth scaling support To: Udit Tiwari , herbert@gondor.apana.org.au, thara.gopinath@gmail.com, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_neersoni@quicinc.com, quic_kuldsing@quicinc.com References: <20260210061437.2293654-1-quic_utiwari@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9ImsX9U2IpRm99OdXlxszVkAS-r0m-qZ X-Proofpoint-ORIG-GUID: 9ImsX9U2IpRm99OdXlxszVkAS-r0m-qZ X-Authority-Analysis: v=2.4 cv=P5k3RyAu c=1 sm=1 tr=0 ts=69959eb6 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=YzaIS8OsZxMseUwa3qEA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDA5OSBTYWx0ZWRfX1t09GJKYVztq h9y4pLlWjzzWFrixC6O5C/+MjF62hREXucsiFRxFnlh/q1tbaXaqwJVzJY9yxw0hoMWDxcKfNr1 5TJBvMnSb72QCkZETHsb763nJ5DmoSiOvywib6qniRrQUPkF7KcwXjAPJAQvgpZ1OT+ERy8U2ge R5Hg1KSUfSXULE8ISqsHQ6ZCkNyCcTMR2ZVpdW2ddevcNFvxqa5Koxq0jjvQFmO572gObmm+HJe +T3ANDrDX1awJKnDmTbwTYYVgzVgLKbRbD/Uu0g2hBjzmHosJSLpqGPU8vpUfgZh/h5iIXRsioy xK5smW46D7GGjJn2viYhGxvcVg28LglwOwDOhZDhP5qGPWnsWh5PZ7zqWhyQEFluoowwccqQIKx sCshWh2DXKMB+vDDzPQk73QnRqFMi9ZUVOLymlbBtSyMuSI1TuUPe8PDY+MEoFNHzZSPMp7LEmU ADibD0gQ2aKqxusq6OQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180099 On 2/18/26 7:02 AM, Udit Tiwari wrote: > Hi Konrad, > > Thanks for pointing this out. > > I agree with your points regarding the usage of the ACQUIRE guard in probe to simplify the error paths, as well as the redundancy of icc_enable in the resume path. I will address both in the next version. > > While preparing the fix, I performed a self-review and noticed a potential issue. Since I am providing my own custom functions for runtime suspend/resume (to handle the ICC path), the standard clock helpers are no longer called automatically by the PM framework. > > I believe I need to manually call pm_clk_resume(dev) and pm_clk_suspend(dev) inside my custom functions to ensure the clocks are actually gated and ungated. > > Does this look correct to you? If you agree, I will include this fix in v7. I tried to find an answer, but it seems like one of these situations where it's easier to add some debug prints than to analyze the code ;) Konrad