Re: [PATCH do not merge 0/4] wifi: mwifiex: add iw61x support

[Marek Vasut <marek.vasut@mailbox.org>]

Hello Sascha,

On 3/26/25 1:18 PM, Sascha Hauer wrote:
> This series adds iw61x support to the mwifiex driver. It works for me,
> but is not yet ready to be merged. Some people showed interest in it, so
> I am sending it here.
> 
> All testing and review feedback appreciated.
> 
> During startup I get these messages:
> 
> [   12.078010] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> [   12.078018] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> [   12.078024] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x23e
> [   12.078029] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x25c
> 
> Not sure what these are about, I can't see these handled in the
> downstream mwifiex driver as well. Could also be there is some parsing
> error. Nevertheless the driver seems to work.
> 
> The series applies to v6.14, but should apply to my mwifiex cleanup
> series as well.

I was able to test these patches with IW610G based muRata 2LL SDIO 
device. I used firmware from [1] and I had to add SDIO ID for that 
IW610G device (trivial patch is below). Besides that, I am adding my:

Tested-by: Marek Vasut <marek.vasut@mailbox.org> # muRata 2LL

Do you plan to finish upstreaming these patches ?

"
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c 
b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 84e3946cc4e4e..54fc82a6e3458 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1049,6 +1049,8 @@ static const struct sdio_device_id mwifiex_ids[] = {
                 .driver_data = (unsigned long)&mwifiex_sdio_sd8987},
         {SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 
SDIO_DEVICE_ID_MARVELL_8997_WLAN),
                 .driver_data = (unsigned long)&mwifiex_sdio_sd8997},
+       {SDIO_DEVICE(SDIO_VENDOR_ID_NXP, 0x0215),
+               .driver_data = (unsigned long)&mwifiex_sdio_iw612},
         {SDIO_DEVICE(SDIO_VENDOR_ID_NXP, SDIO_DEVICE_ID_NXP_IW612_WLAN),
                 .driver_data = (unsigned long)&mwifiex_sdio_iw612},
         {},
"

[1] 
https://github.com/nxp-imx/imx-firmware/tree/lf-6.18.20_2.0.0/FwImage_IW610_SD

Thank you for your help !