From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0809F3D6467 for ; Wed, 18 Mar 2026 13:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839013; cv=none; b=DA1j2u7LdvLW84G0b1SgOu6FPuKZmiYpcJaXmJmZgiVG1ge5QVcIsOTGeIN1BJQfVehDHurV5JlZD9VebSHf9XNi5KqNFykWsW5RbSBD/1UX5JNg1oNE7FAto902o1VeQBd6v2yJLY3bG4ON8BHVclkKw9Swt7dEMa/i5SlFke8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839013; c=relaxed/simple; bh=eonjOcMWk3Gw+Ml9AMDyqJOoLWtXmhPnNQ5RAGU2Y98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BYCqa4FHAqC8E/db+XVpj/pAQPMeI3UUbLkyqjkvL7ihAAw9v5mj4mZGmZxjTihImtR5KpXtJgQbQtEbii/DzAmIyQvPG2W2Xm4XZoVFtNQ+YsBIe8vY9W0joaBG2G8VeBXwTMORlTwDxGD/rw1ykSb6q3jr6mQYTN147w1LLbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=orw/IVxJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="orw/IVxJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4723AC19421; Wed, 18 Mar 2026 13:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773839012; bh=eonjOcMWk3Gw+Ml9AMDyqJOoLWtXmhPnNQ5RAGU2Y98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=orw/IVxJqus17hoDRUQQr1TmOap3CmKo0i4Ed5AAYqTA0zfTOCI6JYrz1kA74ZDvp PdGpF4g1x2wzbWlHVY2IfqI4Aw1C8IqVlYaZCzEN8tDg3TvTPl2j44yJpmR94khS++ pzqhAGV8VtGFq9sggku+7LOscbHn7uDqJJGvuXaRU51H/nJ6o9PxSdIPTOxalIoi4k DFjO06YN/u9YeDdidNVFizXo/yslY8Hj4fWzMo9Upj9fgYbA4W0UVg3RFm+/OihLai XlQF/jSSjCmVjNFd/0ds7RzeU1DjKtQreN6AinEbE42/Zx7sYwqahHmCRboWyGofpi yf0Vj7nH3aGcQ== Date: Wed, 18 Mar 2026 13:03:27 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo , Jann Horn , Sasha Levin , Jiakai Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-hotfixes] mm/rmap: clear vma->anon_vma on error Message-ID: References: <20260318122632.63404-1-ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 01:52:44PM +0100, David Hildenbrand (Arm) wrote: > > Acked-by: David Hildenbrand (Arm) > Thanks! > LGTM. I was wondering whether anon_vma_clone() should take care of > setting up dst->anon_vma. It looks a bit odd in dup_anon_vma. Well in the fork case we don't want to set vma->anon_vma, as we use vma->anon_vma to denote whether or not we reused another anon_vma. For split + remap, we already duplicated it via vm_area_dup() -> vm_area_init_from(). But... now we have enum vma_operation threaded through here, we can just do that there like: /* dst is unfaulted, so inherit src's anon_vma. */ if (operation == VMA_OP_MERGE_UNFAULTED) dst->anon_vma = src->anon_vma; ? > > -- > Cheers, > > David Cheers, Lorenzo