From: Markus Elfring <Markus.Elfring@web.de>
To: "zhong jiang" <zhongjiang@huawei.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Chunming Zhou" <David1.Zhou@amd.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>,
"Kevin Wang" <Kevin1.Wang@amd.com>,
"Tom St Denis" <tom.stdenis@amd.com>,
"Wang Xiayang" <xywang.sjtu@sjtu.edu.cn>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2] drm/amdgpu: Remove two redundant null pointer checks
Date: Thu, 5 Sep 2019 10:23:32 +0200 [thread overview]
Message-ID: <d1aee32e-c9ad-2953-84c0-267037a82288@web.de> (raw)
In-Reply-To: <1567662552-3583-1-git-send-email-zhongjiang@huawei.com>
> The functions "debugfs_remove" and "kfree" tolerate the passing
> of null pointers. Hence it is unnecessary to check such arguments
> around the calls. Thus remove the extra condition check at two places.
Will a tag like “Generated-by: scripts/coccinelle/free/ifnullfree.cocci” be relevant here?
How do you think about to compare this change approach with another patch variant?
drm/amdgpu: Delete an unnecessary check before two function calls
https://lkml.org/lkml/2019/9/4/401
https://lore.kernel.org/patchwork/patch/1123689/
https://lore.kernel.org/r/a3739125-5fa8-cadb-d2b8-8a9f12e9bacd@web.de/
Regards,
Markus
prev parent reply other threads:[~2019-09-05 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 5:49 [PATCH v2] " zhong jiang
2019-09-05 5:55 ` Zhou, David(ChunMing)
2019-09-05 8:23 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1aee32e-c9ad-2953-84c0-267037a82288@web.de \
--to=markus.elfring@web.de \
--cc=David1.Zhou@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Kevin1.Wang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.stdenis@amd.com \
--cc=xywang.sjtu@sjtu.edu.cn \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®