From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF66A47A0BA for ; Wed, 29 Jul 2026 11:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785326081; cv=none; b=DVxq+jR1VP0LDHN27GBHyocw1OHZuPxHciEf/pwa1Kjs7J9jzo2TQqvYnKEzIAZwaZVcJdyLTahbVfAUoF05Tu0fp2Yt5v9sd7rWn93PJXTI9CZkZJYdj5TvuQZuhWlRZjCOLfF+2B4S4uIYaTK+VtBZbP7FVHPvHdvktq6tfgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785326081; c=relaxed/simple; bh=9a9so1CYH3stmaNiF2igDa4SDSwTPoO+r+0jxm4VP3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JPq2fr8IoA79IQaURTCdzRoPidiS7qpRfxMd+CDXxC+5lnJN5wFoAtDcTipSAIYYnIItv1LgaNai63B0SF8UzSETYjP6v+hO6LOGjklt7NiiH4vIsA6KLTSXeP2Ojz9xXtF7HJpUeK22gQT5FgwHY/8e4hwi1zN0XQ4m3vMJGK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ggvTB0Q7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C0ENa+xE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ggvTB0Q7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C0ENa+xE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TBsYWD1637568 for ; Wed, 29 Jul 2026 11:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6FmIKkJTESuL46QyrIupTolyqTQ4VxA4jR8F/WmR/GU=; b=ggvTB0Q7NEWrk2/i ICsIYlqYDS8gh/tIp1vUJE4+a05LTveWQFwroV0Ub/EemjMxEOa5H2eQ913Z/frn ZavclWAelZhQsV+MHSjB7/6b2wqJp6x7ZJfkee7g6QSOFV9smG5rtWRm/GfjYhB9 3pu3F+qhHSlD5yYvo7tmQoSLXMd2awV0/fm3vTXGh34v2FanMpYOLCocn0MNyPBv pOsSHuRHIsrF0JSyMS7ng5EWIHR9IB8AJqOlcwefh2uqyI30+4idgkIN/T3yeKwE imC4VP/xo2wbJYp6PIhfcXM77GFfnVuOFdr36xBtb0msn4+K/oYRpRVZKIWkMoeS L7T0/A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqh2d800p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 11:54:37 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3823dcc1647so1138057a91.3 for ; Wed, 29 Jul 2026 04:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785326077; x=1785930877; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6FmIKkJTESuL46QyrIupTolyqTQ4VxA4jR8F/WmR/GU=; b=C0ENa+xEBxWbcYhrfnxVrzeItm8BIlP7cblcHcreTGP693rE7Vs7L+HI0c9PDQrg4L hyybNsN0rm1uDmStD8x6BNcigDJctzkY/+FpFsFsUTkp4QOL+Gl+fFpFfhIWzfKb/m3j J158TsnljuLxopl5tktQztc4/n95EdjMQpLYUgLKoPA+tfGTq6p2nFTjUE5DkqjuPz/5 0i0CautQ5WaJyGydE6zM0twBY60lIIWSpcZE3XR8HjiuI6FHeG27GwybBuXhuffr6Qvs 2KNh1yF1Pmmcr3zDtosnsQawgML4kkG2/DpBumXPxWopt7KNsEGAK7W/sIlvkE9yBOfH VknA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785326077; x=1785930877; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6FmIKkJTESuL46QyrIupTolyqTQ4VxA4jR8F/WmR/GU=; b=X6RRydGQTzW+ivGZdWapKcj+RtXk2cKjCtj78dlU+/bApPPzWV+G7XK++Dwth9jJzv dR15PDSWpJDlPV7u44LqC8ji7y4njIE6xTI9CGLDx1IgaCi6xw7LurBWPXh+YCTB3xsH +mx8eGms6HwwN2eAGg3dwI0k5weAorMRs9GWAyJxNu0YJgSU4CYrJNKArByjd0y02KAm AJRYPPmxbxzvs/+PeeezzTxU3Js79Dwn8+KiZM05GtWVGhw0I2NPqfgYri2Nl4TRc0hU SqCqq1Aez7KQudYIjjCun94nVYCA/KGCYBAgc8e4VvQ07mRQMTBQNTT2ZHHHIKGW0urc Ymog== X-Forwarded-Encrypted: i=1; AHgh+Rp6ZOwdchVSiLOFjS5rnEs8ggayqff8DiNaO0ZJ9ihg5TRJ4ggIAfrMKEd3Io39XA+8kUmFnismtqeKUaU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3dcmm65Huw/2a+uF6c7VTCxEM8CojA+m3UTzcq/SZv0Iv0UvB JJLUP4IBoX3SVNubHU/vIGgMiKbENM2ECeabJI40mGWsGiDxyzSyDlHwfgX8TlW9PlRKg4okxId PAHIkyTp1x+qKMPwayx2CmTS8p8WtXZEAZ0xYRmQ9BbkEXe4yggES3d3ruSpmjgfppIU= X-Gm-Gg: AR+sD10/0+wMaVoBmJsElvv/mro6be7MXE9IOXwA+RjM3XcEjt19OYjMDD/3hSP9VW4 TuvZc+Do8xCxNTvZZeYryIDEEEKCEgS9xRdWVvhwYWZmagkuY9wgz49CnEvXQuijHbXZol5qGJY JHmS9TzmF4fNN8S0d34ZDO/gNsAbkhsKw3W896hDGZNIv6pgOeV8jth9j9s+NXyCVXupXDoZq54 wjQClmw4WIGL8SQLR3IigUnxeGMO0Wyv2BDIZhEBmXYg04dJ5klwZUyQ7Ij13cQwPMMoOVOaOJi TSgKTjXqBzugZl1XKqAeqtOYVlllz/aV+KEx1krRwoF23X+WH2N0O7BeVr/5oEPDV5LU/ylB1sh dZmSicACuOc7pnUfgOFZcsQKL6/KWpkcW8oEVc8GYiLtBGq/Ld6jJOz2eCV+xYwPTAqUDvvANQ3 6E65dUnEGxmOuU X-Received: by 2002:a17:903:2351:b0:2ce:ed59:7044 with SMTP id d9443c01a7336-2d015d4610bmr68523395ad.30.1785326076794; Wed, 29 Jul 2026 04:54:36 -0700 (PDT) X-Received: by 2002:a17:903:2351:b0:2ce:ed59:7044 with SMTP id d9443c01a7336-2d015d4610bmr68523165ad.30.1785326076380; Wed, 29 Jul 2026 04:54:36 -0700 (PDT) Received: from [10.149.71.180] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bc6d56sm10233465ad.49.2026.07.29.04.54.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 04:54:35 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 17:24:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add qcom,tsens To: Krzysztof Kozlowski , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-1-771abd65ee1a@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=T9m8ifKQ c=1 sm=1 tr=0 ts=6a69e9fd cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=5Skys0qmx9fMEjuPsKYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDA5OCBTYWx0ZWRfX905LgPRoLFJ7 A4XrE3N6wkBzZGFlX2trfdxY08rQSX5A/XaSu7hvCAd6B5M4rssy5w1hk7U2s+m0+ORpK4tNakB f8i9xPZO442Ci1WivUzNmEGHdmFlhar2Lhg3K27yip9myihjWYDVwOdZH+CSijHXUe2l21Mgugt Yht0Si6IfF6GeKLHxEqch4sgJiAvWemEbi8Yk0StP7od5LtOScL69QPDe852XI0/xANPK9uf+Rl JYhi89rhMgrxlPRvmVv7JI5lkgYQPdQqYGJexo8PFqG+tqXEBGvwsb/fi+Ab/1aeD9H/1iA1iGi BcmIWGRBwwFVu8YsaJrKTwoeY0djEXIYKOf0pfmxntXU6nWZ52qNwGi8qPec6AooaGn4YrbX35d qUle0qt7mxH37AArYwU2gyi0je09Cy0Dh4F9bqkJs7tJ5fbcD2D7DamPYjsFsGlFRuNRNRGRJIb BU7I1s50zhYSWFquWIg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDA5OCBTYWx0ZWRfX0WI5Mq6v3crR OnIufwolS6hEMmsaajSGP6J9HgvaFUBhavYgtEW0GBqvPUj5U7RtaYKiVavpAshqulkStyjWVQZ gCE1H/6u3l1EmzxbPcVIgVU6ChgwA/M= X-Proofpoint-ORIG-GUID: 8UrIjceI9OK7Zjw0pQr-27014OCXAC3- X-Proofpoint-GUID: 8UrIjceI9OK7Zjw0pQr-27014OCXAC3- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290098 On 7/29/2026 4:38 PM, Krzysztof Kozlowski wrote: > On 28/07/2026 19:44, Anvesh Jain P wrote: >> Add the qcom,tsens property so Hamoa-based boards can list the tsens >> providers, and how many leading sensor IDs on each, whose readings the >> driver averages to compute the SoC junction temperature reported to >> the EC for fan control. >> >> The generic thermal-sensors property has no standard semantic for >> selecting a range of sensor IDs from a provider without enumerating >> each one, so a vendor-specific phandle-array with an explicit sensor >> count is used instead. >> >> Signed-off-by: Anvesh Jain P >> --- >> .../embedded-controller/qcom,hamoa-crd-ec.yaml | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> index c07483aa5937..ec809fcd03ab 100644 >> --- a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> @@ -33,11 +33,40 @@ properties: >> interrupts: >> maxItems: 1 >> >> + # A generic "thermal-sensors" phandle only identifies individual sensor >> + # IDs, and thermal zones are a Linux-side grouping of those sensors, not >> + # a devicetree concept the EC cares about. What the driver actually needs >> + # is raw readings from a contiguous range of leading sensor IDs on each >> + # tsens provider, averaged together, so qcom,tsens pairs each provider >> + # phandle with a count instead of enumerating every sensor cell. >> + qcom,tsens: > > > What is the point of having internal review and then IGNORE that review? > > NAK > > Best regards, > Krzysztof Krzysztof — for context: I did move to thermal-sensors after your review, but Konrad separately suggested keeping just the provider phandle instead of enumerating every sensor cell, since we only need a leading range per provider. qcom,tsens was meant to combine both suggestions, not ignore yours. Happy to instead just go with your original suggestion and use plain thermal-sensors, enumerating each sensor — let me know which you'd prefer. -- Best Regards, Anvesh