From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F07CC77B73 for ; Wed, 19 Apr 2023 05:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbjDSFDl (ORCPT ); Wed, 19 Apr 2023 01:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjDSFDj (ORCPT ); Wed, 19 Apr 2023 01:03:39 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51E04EE2 for ; Tue, 18 Apr 2023 22:03:37 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1pozyf-0005Aq-O8; Wed, 19 Apr 2023 07:03:33 +0200 Message-ID: Date: Wed, 19 Apr 2023 07:03:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: Linux regressions report for mainline [2023-04-16] Content-Language: en-US, de-DE To: Neal Gompa , Linus Torvalds Cc: David Sterba , David Sterba , linux-kernel@vger.kernel.org, Rafael Wysocki , Chris Mason , Boris Burkov , regressions@lists.linux.dev References: <20230418213228.1273218-1-neal@gompa.dev> From: "Linux regression tracking (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: <20230418213228.1273218-1-neal@gompa.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1681880617;932e380e; X-HE-SMSGID: 1pozyf-0005Aq-O8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.04.23 23:32, Neal Gompa wrote: > > I'm the guy that sort of kickstarted this whole thing a year ago. >>>From my perspective in Fedora-land, we've been running automatic > weekly fstrim on every Fedora system for three years now[1] and > have not received any complaints about SSDs pushing daises from > that. > > When we started discussing btrfs discard=async within Fedora > two years ago[2], I started soliciting feedback and information > from the Btrfs developers I was regularly working with at the time. > > Last year, I had a face-to-face with Chris Mason and we discussed > the idea in depth and decided to go for this, based on both Fedora's > data with consumer disks and Facebook's data with their datacenters. > > The only real surprise we had was the so-called "discard storm", > which Boris Burkov made adjustments to resolve a couple weeks ago[3]. > [...] > [3]: https://lore.kernel.org/linux-btrfs/cover.1680723651.git.boris@bur.io/T/#t Wait, what? Argh. Sorry, if I had seen that patch, I wouldn't have brought this up in my report at all. I missed it, as I wasn't CCed; and regzbot missed it, because the patch uses a odd format for the lore link (but not totally uncommon, will change regzbot to ensure that doesn't happen again). Ciao, Thorsten P.S.: /me meanwhile yet again wonders if we should tell people to add a "CC: " on patches fixing regressions. Then in this case I would have become aware of the patch. And it makes it obvious for anybody handling patches that the patch is fixing a regression. But whatever, might not be worth it.