From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] gpio: tegra: Fix checkpatch warnings
Date: Tue, 25 Jul 2017 09:30:27 +0100 [thread overview]
Message-ID: <d1ba8904-f6a9-70a6-549f-2cba2d2842e3@nvidia.com> (raw)
In-Reply-To: <20170724145508.7388-3-thierry.reding@gmail.com>
On 24/07/17 15:55, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Fix a couple of checkpatch warnings, such as complaints about bare
> unsigned being used (instead of unsigned int) and missing blank lines
> after declarations.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpio/gpio-tegra.c | 32 ++++++++++++++++++++------------
> 1 file changed, 20 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 1d4df290d7ab..edc1a14557f0 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -138,12 +138,12 @@ static void tegra_gpio_disable(struct tegra_gpio_info *tgi, int gpio)
> tegra_gpio_mask_write(tgi, GPIO_MSK_CNF(tgi, gpio), gpio, 0);
> }
>
> -static int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
> +static int tegra_gpio_request(struct gpio_chip *chip, unsigned int offset)
> {
> return pinctrl_request_gpio(offset);
> }
>
> -static void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
> +static void tegra_gpio_free(struct gpio_chip *chip, unsigned int offset)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
>
> @@ -151,14 +151,15 @@ static void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
> tegra_gpio_disable(tgi, offset);
> }
>
> -static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> +static void tegra_gpio_set(struct gpio_chip *chip, unsigned int offset,
> + int value)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
>
> tegra_gpio_mask_write(tgi, GPIO_MSK_OUT(tgi, offset), offset, value);
> }
>
> -static int tegra_gpio_get(struct gpio_chip *chip, unsigned offset)
> +static int tegra_gpio_get(struct gpio_chip *chip, unsigned int offset)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
> int bval = BIT(GPIO_BIT(offset));
> @@ -170,7 +171,8 @@ static int tegra_gpio_get(struct gpio_chip *chip, unsigned offset)
> return !!(tegra_gpio_readl(tgi, GPIO_IN(tgi, offset)) & bval);
> }
>
> -static int tegra_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> +static int tegra_gpio_direction_input(struct gpio_chip *chip,
> + unsigned int offset)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
>
> @@ -179,8 +181,9 @@ static int tegra_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> return 0;
> }
>
> -static int tegra_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> - int value)
> +static int tegra_gpio_direction_output(struct gpio_chip *chip,
> + unsigned int offset,
> + int value)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
>
> @@ -190,7 +193,8 @@ static int tegra_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> return 0;
> }
>
> -static int tegra_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +static int tegra_gpio_get_direction(struct gpio_chip *chip,
> + unsigned int offset)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
> u32 pin_mask = BIT(GPIO_BIT(offset));
> @@ -250,7 +254,7 @@ static int tegra_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
> return tegra_gpio_set_debounce(chip, offset, debounce);
> }
>
> -static int tegra_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
> +static int tegra_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
> {
> struct tegra_gpio_info *tgi = gpiochip_get_data(chip);
>
> @@ -413,7 +417,8 @@ static int tegra_gpio_resume(struct device *dev)
> struct tegra_gpio_bank *bank = &tgi->bank_info[b];
>
> for (p = 0; p < ARRAY_SIZE(bank->oe); p++) {
> - unsigned int gpio = (b<<5) | (p<<3);
> + unsigned int gpio = (b << 5) | (p << 3);
> +
> tegra_gpio_writel(tgi, bank->cnf[p],
> GPIO_CNF(tgi, gpio));
>
> @@ -452,7 +457,8 @@ static int tegra_gpio_suspend(struct device *dev)
> struct tegra_gpio_bank *bank = &tgi->bank_info[b];
>
> for (p = 0; p < ARRAY_SIZE(bank->oe); p++) {
> - unsigned int gpio = (b<<5) | (p<<3);
> + unsigned int gpio = (b << 5) | (p << 3);
> +
> bank->cnf[p] = tegra_gpio_readl(tgi,
> GPIO_CNF(tgi, gpio));
> bank->out[p] = tegra_gpio_readl(tgi,
> @@ -513,6 +519,7 @@ static int dbg_gpio_show(struct seq_file *s, void *unused)
> for (i = 0; i < tgi->bank_count; i++) {
> for (j = 0; j < 4; j++) {
> int gpio = tegra_gpio_compose(i, j, 0);
> +
> seq_printf(s,
> "%d:%d %02x %02x %02x %02x %02x %02x %06x\n",
> i, j,
> @@ -542,7 +549,7 @@ static const struct file_operations debug_fops = {
>
> static void tegra_gpio_debuginit(struct tegra_gpio_info *tgi)
> {
> - (void) debugfs_create_file("tegra_gpio", S_IRUGO,
> + (void) debugfs_create_file("tegra_gpio", 0444,
> NULL, tgi, &debug_fops);
> }
>
> @@ -653,6 +660,7 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> for (i = 0; i < tgi->bank_count; i++) {
> for (j = 0; j < 4; j++) {
> int gpio = tegra_gpio_compose(i, j, 0);
> +
> tegra_gpio_writel(tgi, 0x00, GPIO_INT_ENB(tgi, gpio));
> }
> }
>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2017-07-25 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 14:55 [PATCH 1/4] gpio: tegra: Remove unnecessary check Thierry Reding
2017-07-24 14:55 ` [PATCH 2/4] gpio: tegra: Prefer kcalloc() over kzalloc() with multiplies Thierry Reding
2017-07-25 8:27 ` Jon Hunter
2017-08-02 12:16 ` Linus Walleij
2017-07-24 14:55 ` [PATCH 3/4] gpio: tegra: Fix checkpatch warnings Thierry Reding
2017-07-25 8:30 ` Jon Hunter [this message]
2017-08-02 12:18 ` Linus Walleij
2017-07-24 14:55 ` [PATCH 4/4] gpio: tegra: Use unsigned int where possible Thierry Reding
2017-07-25 9:16 ` Jon Hunter
2017-07-25 8:27 ` [PATCH 1/4] gpio: tegra: Remove unnecessary check Jon Hunter
2017-07-31 11:00 ` Thierry Reding
2017-08-02 12:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ba8904-f6a9-70a6-549f-2cba2d2842e3@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®