From: Krzysztof Kozlowski <krzk@kernel.org>
To: Markuss Broks <markuss.broks@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Maksym Holovach <nergzd@nergzd723.xyz>
Subject: Re: [PATCH RESEND v4 1/2] arm64: dts: exynos: Add Exynos9810 SoC support
Date: Sun, 22 Dec 2024 15:46:53 +0100 [thread overview]
Message-ID: <d1c6d2f2-f733-4cbe-8108-c9c9aaa417cc@kernel.org> (raw)
In-Reply-To: <20241214-exynos9810-v4-1-4e91fbbc2133@gmail.com>
On 14/12/2024 15:56, Markuss Broks wrote:
> + pinctrl0 = &pinctrl_alive;
> + pinctrl1 = &pinctrl_aud;
> + pinctrl2 = &pinctrl_chub;
> + pinctrl3 = &pinctrl_cmgp;
> + pinctrl4 = &pinctrl_fsys0;
> + pinctrl5 = &pinctrl_fsys1;
> + pinctrl6 = &pinctrl_peric0;
> + pinctrl7 = &pinctrl_peric1;
> + pinctrl8 = &pinctrl_vts;
> + };
> +
> + arm-a55-pmu {
> + compatible = "arm,cortex-a55-pmu";
> + interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-affinity = <&cpu0>,
> + <&cpu1>,
> + <&cpu2>,
> + <&cpu3>;
> + };
> +
> + mongoose-m3-pmu {
So the name chosen by previous people some time ago for arm PMU is
obviously not the best - forces either messed sorting or having PMU
nodes in different places. That's why people should almost always go
with prefix, no suffix. See regulators and clocks.
Fixed and applied.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-22 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-14 14:56 [PATCH RESEND v4 0/2] Add support for Exynos9810 SoC and Samsung Galaxy S9 (SM-G960F) Markuss Broks
2024-12-14 14:56 ` [PATCH RESEND v4 1/2] arm64: dts: exynos: Add Exynos9810 SoC support Markuss Broks
2024-12-22 14:46 ` Krzysztof Kozlowski [this message]
2024-12-14 14:56 ` [PATCH RESEND v4 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy S9 (SM-G960F) Markuss Broks
2024-12-22 14:47 ` [PATCH RESEND v4 0/2] Add support for Exynos9810 SoC and " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c6d2f2-f733-4cbe-8108-c9c9aaa417cc@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=markuss.broks@gmail.com \
--cc=nergzd@nergzd723.xyz \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®