From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23046CDB474 for ; Mon, 23 Oct 2023 11:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233421AbjJWLHI (ORCPT ); Mon, 23 Oct 2023 07:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233406AbjJWLHG (ORCPT ); Mon, 23 Oct 2023 07:07:06 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82E4DD7F for ; Mon, 23 Oct 2023 04:07:04 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8195F66056D1; Mon, 23 Oct 2023 12:07:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698059223; bh=ZPYct6TKPhXnwWujFdM+whLqN4S0h84pY9ooYkcyhfU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ZmpjuItuKqDzcvKhkTGQ3aOxdbFgtc9cKGZmWMS2Pl2MP66OX0vrBjUF2t9m5hpSW 8baH8ixIFNnK3661E9pO6zpI6M1wPVoo8txnxIPC2ZtGAl6jPTVIKEetRb5L+77Xmw l1YjXzrrSNtubejjbOmTPVkzZltSqYNH65Xm8j+JUuua7tyYkfXYn7vg1A9dmwjatk eb6PsUzZyKaxJp1Niy538gGG0ejv8ZU76Uux3lkR4r3HXreHsZcWs9H09iiluK6rUG 6fifRdjbUbyRuanhPkA3Vgo4jewDrPDUaIEZlbB2xxER9X4+frxPSBN6ThhKzV1j+c aRscoCphKQPxg== Message-ID: Date: Mon, 23 Oct 2023 13:07:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ASoC: mediatek: mt7986: add sample rate checker Content-Language: en-US To: Maso Huang , Liam Girdwood , Mark Brown , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20231023095453.4860-1-maso.huang@mediatek.com> <20231023095453.4860-3-maso.huang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231023095453.4860-3-maso.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 23/10/23 11:54, Maso Huang ha scritto: > mt7986 only supports 8/12/16/24/32/48/96/192 kHz > > Signed-off-by: Maso Huang > --- > sound/soc/mediatek/mt7986/mt7986-dai-etdm.c | 22 +++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c b/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c > index e523d33846fe..270852ce3dd9 100644 > --- a/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c > +++ b/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c > @@ -237,12 +237,26 @@ static int mtk_dai_etdm_hw_params(struct snd_pcm_substream *substream, > struct snd_pcm_hw_params *params, > struct snd_soc_dai *dai) > { > + unsigned int rate = params_rate(params); > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > > - mtk_dai_etdm_config(afe, params, dai, SNDRV_PCM_STREAM_PLAYBACK); > - mtk_dai_etdm_config(afe, params, dai, SNDRV_PCM_STREAM_CAPTURE); > - > - return 0; > + switch (rate) { > + case 8000: > + case 12000: > + case 16000: > + case 24000: > + case 32000: > + case 48000: > + case 96000: > + case 192000: > + mtk_dai_etdm_config(afe, params, dai, SNDRV_PCM_STREAM_PLAYBACK); > + mtk_dai_etdm_config(afe, params, dai, SNDRV_PCM_STREAM_CAPTURE); > + return 0; > + default: > + dev_warn(afe->dev, "%s(), sample rate: %d is not supported\n", __func__, rate); > + dev_warn(afe->dev, "%s(), only support 8/12/16/24/32/48/96/192 kHz\n", __func__); That's better: dev_err(afe->dev, "Sample rate %d invalid. Supported rates: 8/12/16/24/32/48/96/192 kHz\n", rate, __func__); after which, Reviewed-by: AngeloGioacchino Del Regno Regards, Angelo