From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3DE3570DA for ; Mon, 2 Feb 2026 10:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027272; cv=none; b=i0kptYnDwIJ629APi9M20Y8uPRDsPUqa6Hiv4JiWt3/r0nzHdqZHJl/816ayk9MgLV7BnIpSjgWtzLdqpIxTxZQnkqnKlgOyOnnX9/VgtkEAL/pHMK2iRg25A8eYSOlF3YA9t5MP+0SR68ihF9McZa/yalW7lQlTv+vAoahlcKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027272; c=relaxed/simple; bh=8VzmCD6zmthbjJ6e29NsFnoebW8tRXPgQWLhoogWYDk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=DoV9g5T/et8xm4Sc70tE9qQBMYDrVVQBlnTYnNmTH8DuJgiclhi33T+NeQPjEcJSY8ILkHCMLOyplNV48yuyO/9VETsCdNa57KqyOKnivIY2Jxu8YXrbtM313WD2zuKFm56806XbQmyQJN2jZgHYO7wHoC7c2D9VrrcOXTBexYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PkyEPkwj; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PkyEPkwj" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4801ea9bafdso17430765e9.3 for ; Mon, 02 Feb 2026 02:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770027270; x=1770632070; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qrYZR6rjkuzxmU3P4nDHzp2Z/smbaycErCPCyN/9Pdo=; b=PkyEPkwjq8nlF8HnND3XJr8eZb2DGW/dH+4Q/9AI6w4qYoXJH+N4aChpBvFQFl2EMz cgtmu+2oIhrwyIOuj7B9M6rqURKzA2t5TQkGHwIEQzpfV8zFeXMYpTiiBZF7Vc1TkI1x LuzaUEJRQkYADLzeCFyfFyaFg7YvwpCJ/P81b04taF4YNCo9GRGJurGcJkUVpf4wZvzI 0HYgyPJPZCWZusyy9X3ZUXz+wjkEeBdH1EAJZLepfLKdDXKQUWrBzbW2KHa3cjQ9HUvq oY/Nh8IqShYySpEuye75Lyq4YMz/aGg4LPT7Tjg116r+SuqT8H9N0mxoegD/+inlTr/T ytzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770027270; x=1770632070; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrYZR6rjkuzxmU3P4nDHzp2Z/smbaycErCPCyN/9Pdo=; b=QrfgVWd+TQRMjmzamEwfkP3S84C8R9U2NEw3BLDaNz35XCVDt3GfERBv2wq1V4JrQZ jab4hXvvzgkIkln4ispHMhRbhwnHRoFnL2Cqc1Tid9zCCuIhKIeuQbhnEASBqmcWv75k pIQjGTw6R3I+JQflPuc3aym8XWOdqjr87/UzPKd8Ltr4Wx/IqOnycbjM7oej0GdIzpJO DACb5YYO89I2dXOlOMk3L84f4b5Z+NaJfJJxK+nHxANnhVhZE9CFINJFdJK/iFuMsHbq r1shsHUheCoKGgJQno2S22Opx2RPASbj5oHyg1CtJ2av4Tox7IRsvgJrn6x1sLx+CGhh O+CA== X-Forwarded-Encrypted: i=1; AJvYcCUpa5Sa1A0lWc+/cbCourEh60t/Fkae+8252q+JHTEkGQD1RzP9tNi1Aw9MbxI2Yjt9ahqz8Majk09lWE4=@vger.kernel.org X-Gm-Message-State: AOJu0YxR1ICBMjZW3EVksmEPoR6aQemd2ScgIG5hIAb+cKKqf/gssqwI i1KkS14TxKVu2bJTN7g74Bu9ivYmwOcn+sNY8weFtN15ihC4B8cfxKDL X-Gm-Gg: AZuq6aI4k5vJbBao47Fu7E+03SomKsBvBBBBSckQ3MGRmNDzSvh9q/ZyFDXoBrKYunK Muvu9iwrobHcpJFYiCZe1YbeIQdzSYbYiq0s2cZ6lKDJYz+MWS+xPd5WHTYpuMJTAuxBFOs09gv v24BR5ZrlbHJ9vjOvn0c2O/8JMioikH1GZgOPxoIYNMvbQPmp8bs6dgcnMKnQ5/WFGI+atvG3L7 TRnuR2nJ6moclhIqAcx0c9q2c76Lhg4bW6EJcczQRyBkQ622W5IQ73ax6CxIoXGGUE7ziALH1Lp FCC/kTVetswTiRQUPHjhuIx1YWhJ1arhcPfdcpiv04plT4ACOu6h5N0pAndT9i1o5fMzWT4lM1P V3ZkWrKrScFnIDSdf2cJHulIHj64RxrkzJWr1d9KCOemBjItjHviLOcx7Yf2W68PwsKiFi6EjkL lq5btTPqXdi2HIgBW1I+k= X-Received: by 2002:a05:600c:6298:b0:480:5951:fc1e with SMTP id 5b1f17b1804b1-482db45fbf4mr141852155e9.11.1770027269821; Mon, 02 Feb 2026 02:14:29 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482da8eb486sm109926285e9.2.2026.02.02.02.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 02:14:29 -0800 (PST) Message-ID: Subject: Re: [PATCH net-next] net: ethernet: adi: adin1110: Check return value of devm_gpiod_get_optional() in adin1110_check_spi() From: Nuno =?ISO-8859-1?Q?S=E1?= To: Chen Ni , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kuniyu@google.com, nicolas.dichtel@6wind.com, alexandru.tachici@analog.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 02 Feb 2026 10:15:11 +0000 In-Reply-To: <20260202040228.4129097-1-nichen@iscas.ac.cn> References: <20260202040228.4129097-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-02 at 12:02 +0800, Chen Ni wrote: > The devm_gpiod_get_optional() function may return an ERR_PTR in case of > genuine GPIO acquisition errors, not just NULL which indicates the > legitimate absence of an optional GPIO. >=20 > Add an IS_ERR() check after the call in adin1110_check_spi(). On error, > return the error code to ensure proper failure handling rather than > proceeding with invalid pointers. >=20 > Fixes: 36934cac7aaf ("net: ethernet: adi: adin1110: add reset GPIO") > Signed-off-by: Chen Ni > --- For the change itself: Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/net/ethernet/adi/adin1110.c | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/a= di/adin1110.c > index 30f9d271e595..71a2397edf2b 100644 > --- a/drivers/net/ethernet/adi/adin1110.c > +++ b/drivers/net/ethernet/adi/adin1110.c > @@ -1089,6 +1089,9 @@ static int adin1110_check_spi(struct adin1110_priv = *priv) > =C2=A0 > =C2=A0 reset_gpio =3D devm_gpiod_get_optional(&priv->spidev->dev, "reset"= , > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 GPIOD_OUT_LOW); > + if (IS_ERR(reset_gpio)) > + return dev_err_probe(&priv->spidev->dev, PTR_ERR(reset_gpio), > + =C2=A0=C2=A0=C2=A0=C2=A0 "failed to get reset gpio\n"); > =C2=A0 if (reset_gpio) { > =C2=A0 /* MISO pin is used for internal configuration, can't have > =C2=A0 * anyone else disturbing the SDO line.