From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E7DC433EF for ; Thu, 10 Feb 2022 16:36:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244326AbiBJQgz (ORCPT ); Thu, 10 Feb 2022 11:36:55 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244267AbiBJQgw (ORCPT ); Thu, 10 Feb 2022 11:36:52 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C34C0128 for ; Thu, 10 Feb 2022 08:36:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644511011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqSpSbLAke/1OnLd6EmGmfWxLdKIpRgwdlPw5Vgh4vE=; b=ElqIO/0CrkZOnKLP5RogCOAFlI0RNnAcQzDSQVdzxPHP1EMij87lrqHrY9qsmN6gROnogG HLp03RliVOm79dnCEHFa03G/9MERhPX6+PoqPZ6tZ0y/jb45YYMwufr5SLuH7efJq3NwQL /fzF+SLVz9rCKnnuIWoQ6l2Nbr12IkA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-530-cM05wTXPPzG5aQg6ZNmeNQ-1; Thu, 10 Feb 2022 11:36:50 -0500 X-MC-Unique: cM05wTXPPzG5aQg6ZNmeNQ-1 Received: by mail-ed1-f70.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso3641278edt.20 for ; Thu, 10 Feb 2022 08:36:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UqSpSbLAke/1OnLd6EmGmfWxLdKIpRgwdlPw5Vgh4vE=; b=c65ocYu88A6LKjP57HDEVgna8bINb9KudcYPiMYgF7uuX3XMBAbYYR5CzgG1+28zHZ PDevz0RBtwOe6Vh1J727yqME8mIFFp5To3ubfdXR+jOQJGDnxdTwrspiUp+mGc/n7suI I7fe/sjGsRJacQ9WEwfHdjPUZeiobFUGP8Qw0VOp072GQ07Iep1SioBKiaIUe4xLoNZk +xzivWaUoMFaB0NECQq9v4nn53loCA3Bi06EzX32npNZUUHLgu0xkmUGdtYXWUILLfc7 xT1H2lv6P84OVs/gtGtUNdk/Jprc/DTN+XbgNad5kpG032AR/71ronZyAKz5AiMr249L YHig== X-Gm-Message-State: AOAM5300q2q3ukBE/LIhiYtsLVsVwZ4ieBX/8iD9ZR7aywPmIYdYDQoP zlH3auRDaurIrAiPCcxMthztuYczyxWqP9I+tq0T4HKRMdEMuNXytXfMPC2Zxg6tdhSXrHUhLth +RmfH1R7h4kkh9Mct6LQCsZxc X-Received: by 2002:a17:907:c01a:: with SMTP id ss26mr7188161ejc.734.1644511008858; Thu, 10 Feb 2022 08:36:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsICHo+zXE5V4n/hNFUlselQb7/jJjtRQ0Tylf3AFGMRI+O1AdLAbOvro//iFc+e5nfma5eg== X-Received: by 2002:a17:907:c01a:: with SMTP id ss26mr7188140ejc.734.1644511008634; Thu, 10 Feb 2022 08:36:48 -0800 (PST) Received: from [192.168.10.118] ([93.56.170.240]) by smtp.googlemail.com with ESMTPSA id m25sm7118243edr.104.2022.02.10.08.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 08:36:47 -0800 (PST) Message-ID: Date: Thu, 10 Feb 2022 17:35:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH MANUALSEL 5.4 1/2] KVM: nVMX: eVMCS: Filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vitaly Kuznetsov , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org References: <20220209185733.49157-1-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220209185733.49157-1-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 19:57, Sasha Levin wrote: > From: Vitaly Kuznetsov > > [ Upstream commit 7a601e2cf61558dfd534a9ecaad09f5853ad8204 ] Acked-by: Paolo Bonzini Paolo > Enlightened VMCS v1 doesn't have VMX_PREEMPTION_TIMER_VALUE field, > PIN_BASED_VMX_PREEMPTION_TIMER is also filtered out already so it makes > sense to filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER too. > > Note, none of the currently existing Windows/Hyper-V versions are known > to enable 'save VMX-preemption timer value' when eVMCS is in use, the > change is aimed at making the filtering future proof. > > Signed-off-by: Vitaly Kuznetsov > Message-Id: <20220112170134.1904308-3-vkuznets@redhat.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kvm/vmx/evmcs.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/evmcs.h b/arch/x86/kvm/vmx/evmcs.h > index 07ebf6882a458..632bed227152e 100644 > --- a/arch/x86/kvm/vmx/evmcs.h > +++ b/arch/x86/kvm/vmx/evmcs.h > @@ -58,7 +58,9 @@ DECLARE_STATIC_KEY_FALSE(enable_evmcs); > SECONDARY_EXEC_SHADOW_VMCS | \ > SECONDARY_EXEC_TSC_SCALING | \ > SECONDARY_EXEC_PAUSE_LOOP_EXITING) > -#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL) > +#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL \ > + (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | \ > + VM_EXIT_SAVE_VMX_PREEMPTION_TIMER) > #define EVMCS1_UNSUPPORTED_VMENTRY_CTRL (VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL) > #define EVMCS1_UNSUPPORTED_VMFUNC (VMX_VMFUNC_EPTP_SWITCHING) >