mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	quic_srivasam@quicinc.com
Subject: Re: [PATCH 01/10] ASoC: codecs: va-macro: add runtime pm support
Date: Mon, 21 Feb 2022 15:27:19 +0000	[thread overview]
Message-ID: <d1d55fd2-68a8-9271-00c5-b395b085b50c@linaro.org> (raw)
In-Reply-To: <YhOuvdsKu6zOg2p/@sirena.org.uk>

Thanks Mark,

On 21/02/2022 15:24, Mark Brown wrote:
> On Mon, Feb 21, 2022 at 01:10:28PM +0000, Srinivas Kandagatla wrote:
> 
>> +static int __maybe_unused va_macro_runtime_resume(struct device *dev)
>> +{
>> +	struct va_macro *va = dev_get_drvdata(dev);
>> +
>> +	clk_prepare_enable(va->clks[2].clk);
> 
> This magic number stuff is going to be excessively fragile, and the fact

I agree, will try to clean this up properly in next spin.

> that this is sometimes managed via the bulk APIs and sometimes not isn't
> going to help either.  Either all the clocks should be managed here or
> this should be pulled out of the array.
> 
> Also consider error checking.
will do,

--srin

  reply	other threads:[~2022-02-21 15:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 13:10 [PATCH 00/10] ASoC: codec: add pm runtime support for Qualcomm codecs Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 01/10] ASoC: codecs: va-macro: add runtime pm support Srinivas Kandagatla
2022-02-21 15:24   ` Mark Brown
2022-02-21 15:27     ` Srinivas Kandagatla [this message]
2022-02-21 13:10 ` [PATCH 02/10] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 03/10] ASoC: codecs: rx-macro: " Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 04/10] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 05/10] ASoC: codecs: wsa881x: " Srinivas Kandagatla
2022-02-22 19:53   ` Pierre-Louis Bossart
2022-02-21 13:10 ` [PATCH 06/10] ASoC: codecs: wcd938x: add simple clk stop support Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 07/10] ASoC: codecs: wcd-mbhc: add runtime pm support Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 08/10] ASoC: codecs: wsa-macro: setup soundwire clks correctly Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 09/10] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-21 15:38   ` Mark Brown
2022-02-21 16:11     ` Srinivas Kandagatla
2022-02-21 16:48       ` Mark Brown
2022-02-22 12:08         ` Srinivas Kandagatla
2022-02-21 13:10 ` [PATCH 10/10] ASoC: codecs: rx-macro: " Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1d55fd2-68a8-9271-00c5-b395b085b50c@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_srivasam@quicinc.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®