From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7122C3385AE for ; Fri, 9 Jan 2026 11:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767956967; cv=none; b=H437tVpsQZ74+VYa+jeJy5UkSwdMQTX2nlNAUIS4hOkaEfEYAW9Eqt0mVhori4kPEcDlEDtIkYKU3vObeW2Yl+K7M2VjuFEI7XR90f6AmtcriTNMeFtspOD+23EcodvhQuyUYsYAUVFqZnVXr3V3HOW5EOSdjehU+3lAIs9Ogag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767956967; c=relaxed/simple; bh=8Xq5WIfVuMEOt90CrULMH4IpO5y3+EIFJpPu7WTMeHY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bC0qmOpoyrD0QwsrEI/EzMU4hs6A8oecpg6dAnA+/E9c2B5abMqUi4d+KonEQFf/AqYsi6EQVxnor0gfq0xI6DxbT8pJNMXwqmRuhfFw6qiCbHypw9H3QAw128GAmDNuWGW5Em0eLrOpraqj8PFn6tV8Kyo63tgKE7WqPmPVKrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AcvtOMmg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=J7RnPXVo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AcvtOMmg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="J7RnPXVo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767956961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+WLh4YdMT4BQhhiGpX2c08r18nWKZ1SS4NAmL7UFi+k=; b=AcvtOMmgnLq+QlPIwBz5Lz3IzDkYz3YOKeNe1fQ0o9txHPu+geShjKefFVLMRj8XalDnqK Dc2KP0Ro7JnUpoXLDmp8nhDD3cY02pGwxT2kGL0JsKAKgk7uRDTIp3TmLe4UiI2GOJQ79D rl3PeMaX26FodR+016Ncjh51Fr7NwoM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-lTdw4tyMM5W3lYPMwmQTKA-1; Fri, 09 Jan 2026 06:09:20 -0500 X-MC-Unique: lTdw4tyMM5W3lYPMwmQTKA-1 X-Mimecast-MFC-AGG-ID: lTdw4tyMM5W3lYPMwmQTKA_1767956959 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-59b67b93cf5so3103619e87.0 for ; Fri, 09 Jan 2026 03:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767956959; x=1768561759; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+WLh4YdMT4BQhhiGpX2c08r18nWKZ1SS4NAmL7UFi+k=; b=J7RnPXVoztXjEtxX/wWT9c2H5+z6/aG0e+fjkLzGG1jLKUX/cf5CznekcXciB75Ct2 6AEX7kgH1PG/3g71JciCewxp+RJj7ynKYljWuKuAn4hBauRTZZaCNJ1KwqrW2OHkgfxt O8Hrl3Iu/zGSiaWoPJwDQ0wfMGXkiu+ToPfVMvL6R5lO5ul0KP4uf7CQztCMG7vV2bnD mwt/u87ux2jnlFEzISWFOgEYOR1K8qWudm9hn4usJmr/4cALg6xmGAptnhJIkrsFjuhp 5TwZ3OYYuTfEUnS8JgNnUoVNtbcdxaQb0Izw/Sqdclt/NoD3Kr5GVJxj6svhV7E6xxxR Jw3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767956959; x=1768561759; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+WLh4YdMT4BQhhiGpX2c08r18nWKZ1SS4NAmL7UFi+k=; b=SAL4XP7U8mww1JOoo2H4wDpgOSX626zsGtlmjrrbEu32MIMT2Ik/gQv/7/DurQ78XU I6F/B10tNGfpu9lCsJ3IiocOW5OCagMt43AnSXyyzzzglWw3hahvPCI1H+uD6lh699ft x0G6EAJOxfj00W0uHKycyYyXE0F05NNrN/n6tjxlJkZdXEv03/C2P7yn8h7vIfMKlLuT APRa75vnkasQSUkaksgBzGGaNtyHbFgEXpdrQZS9T0qkqtC97Y/d0z0qse76wzvAYBJK kkX+xfCdMmOM+/7SS4Kor1kRDVo5KCBiWSZjlPqYY9Sc6B+HVAHLt8GdQlNWv+PP2Rtd o+Pw== X-Forwarded-Encrypted: i=1; AJvYcCWwQSg0FKx2/yI4Dpne0a/Hxg1FaXAuVVocEgVD9XAj7feoEUdpdXlEdtoF093cUHWaehUq5OjsG0X0afw=@vger.kernel.org X-Gm-Message-State: AOJu0YztHJjtokjWhPXFhrTsze1jPpDqQKvoGVyDK2c4kqeTpGnDwB1Y WinPwAZgC2E6s3GCVDPki6otYHJ7xhch1WnlDPOxTMDCSWTfnnbcQTwDhbtjSahWW+p8h6p5kIM b568EwDEJmXEk/KcuN+0QvUt7v1C9RDKd/DPP8JsotkBBUCybCyqyBsmSAJVcpZXU X-Gm-Gg: AY/fxX5LATPvhtMynQdK8nekIFIbNGmh8G4XyUEmr0RlE98OMX8IfalUTyMw8vaNTgI 9OruKGgfRvZfxdv2cI0ZtthJCMNRc6w9nmbBkR3jEgOiXoQMo2mcEpRTzu9H1TIA4CTjD1CsQHS ZIW0m1CCTkH9dljUIeXM7l770GG+N10GPE/1Uq+exlwtcSwCKlXkY+6XMh5wj8lHBNHekVFG2PE wi55JJrsuyIq9jNBpHu/9pwCghLq4NYYYkgNahylrgHXJY4+w7lU29u35U/M4FhzhkfuH3Vlh6A 4/VN8GzWDfz8XKlv7qak8IaseFj6tY0PL4VnvaS2k6cExjU/caWLpkZm4U2gSwDy4kCLYWd6+M2 kdZyKwDEoCnAF8FdLCD3vB9luwFeBWmwnZrY= X-Received: by 2002:a05:6512:138c:b0:595:840c:cdd0 with SMTP id 2adb3069b0e04-59b6ef23821mr2942334e87.2.1767956958661; Fri, 09 Jan 2026 03:09:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1Kdn6xqqEz7oS8njPdOYi3SCUUHgKoVYObUp3Vur8XucGkM8H4lTSJgH2gDE+3acZOyL3Ug== X-Received: by 2002:a05:6512:138c:b0:595:840c:cdd0 with SMTP id 2adb3069b0e04-59b6ef23821mr2942314e87.2.1767956958199; Fri, 09 Jan 2026 03:09:18 -0800 (PST) Received: from [192.168.1.86] (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59b65d0f6absm2716455e87.42.2026.01.09.03.09.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 03:09:17 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 13:09:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/7] mm: Split device-private and coherent folios before freeing To: Francois Dugast , intel-xe@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Matthew Brost , Balbir Singh , Alistair Popple , Zi Yan , David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260109085605.443316-1-francois.dugast@intel.com> <20260109085605.443316-4-francois.dugast@intel.com> Content-Language: en-US From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: <20260109085605.443316-4-francois.dugast@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 1/9/26 10:54, Francois Dugast wrote: > From: Matthew Brost > > Split device-private and coherent folios into individual pages before > freeing so that any order folio can be formed upon the next use of the > pages. > > Cc: Balbir Singh > Cc: Alistair Popple > Cc: Zi Yan > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-cxl@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Matthew Brost > Signed-off-by: Francois Dugast > --- > mm/memremap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 63c6ab4fdf08..7289cdd6862f 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -453,6 +453,8 @@ void free_zone_device_folio(struct folio *folio) > case MEMORY_DEVICE_COHERENT: > if (WARN_ON_ONCE(!pgmap->ops || !pgmap->ops->folio_free)) > break; > + > + folio_split_unref(folio); > pgmap->ops->folio_free(folio); > percpu_ref_put_many(&folio->pgmap->ref, nr); > break; This breaks folio_free implementations like nouveau_dmem_folio_free which checks the folio order and act upon that. Maybe add an order parameter to folio_free or let the driver handle the split? Thanks, Mika